From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C42C433EF for ; Sat, 5 Mar 2022 13:29:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE2066B009F; Sat, 5 Mar 2022 08:29:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C91856B00A0; Sat, 5 Mar 2022 08:29:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7F4B6B00A1; Sat, 5 Mar 2022 08:29:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id A6D986B009F for ; Sat, 5 Mar 2022 08:29:02 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 52C959EB2C for ; Sat, 5 Mar 2022 13:29:02 +0000 (UTC) X-FDA: 79210413324.17.DECD023 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id C2C0540003 for ; Sat, 5 Mar 2022 13:29:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82690B80968; Sat, 5 Mar 2022 13:29:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73F4AC004E1; Sat, 5 Mar 2022 13:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646486939; bh=vYvP7056BHk7rl1Y96vla2BZ2Uo/2Pb6tDGrV6v4z4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W1Nzq1ovp65BGoS79tdDDeAGZcrYlvcwIP+/fBBgTc52YdLqizvBCULP6O5lwf/7V 0XacYp/4qgfISo9A8lDOnzUftO/fLmhvkvLZAvx6tgy7i+cd5UESXi7cccPQ8saNgS 0AS4gcygqiwqxV8Ek5nbD7xCHnw8vd20zQDG56T50uGPrx3qwvlhDjjp0rU2Jr2Kur cA0k3skgVYTrK/jRqpNgGeXPXhA55dT8/Lx9XpbijQcNXOQbgcOch5oOElwLOn2nqi GF20tc+6krwNMKkYOBRXj0W/S7jr9ZKn4eyImSnSLKgxoDs2TjO9uCtBTLvqX8rcp7 xpVfCV+20Hgtw== Date: Sat, 5 Mar 2022 15:28:51 +0200 From: Mike Rapoport To: Tiezhu Yang Cc: Thomas Bogendoerfer , Andrew Morton , Xuefeng Li , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/4] memblock: Introduce memblock_mem_range_remove_map() Message-ID: References: <1646461289-31992-1-git-send-email-yangtiezhu@loongson.cn> <1646461289-31992-2-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1646461289-31992-2-git-send-email-yangtiezhu@loongson.cn> X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: uibximrb1k8w8toqm9r3fbbfhqym39fe Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=W1Nzq1ov; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Queue-Id: C2C0540003 X-HE-Tag: 1646486941-680901 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 05, 2022 at 02:21:26PM +0800, Tiezhu Yang wrote: > This is preparation for supporting mem=limit@base and memmap=limit@base > parameters, no functionality change. > > Signed-off-by: Tiezhu Yang NAK. We already have enough memory capping interfaces in memblock, we don't need yet another one. > --- > include/linux/memblock.h | 1 + > mm/memblock.c | 9 +++++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 50ad196..e558d2c 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -482,6 +482,7 @@ phys_addr_t memblock_end_of_DRAM(void); > void memblock_enforce_memory_limit(phys_addr_t memory_limit); > void memblock_cap_memory_range(phys_addr_t base, phys_addr_t size); > void memblock_mem_limit_remove_map(phys_addr_t limit); > +void memblock_mem_range_remove_map(phys_addr_t base, phys_addr_t limit); > bool memblock_is_memory(phys_addr_t addr); > bool memblock_is_map_memory(phys_addr_t addr); > bool memblock_is_region_memory(phys_addr_t base, phys_addr_t size); > diff --git a/mm/memblock.c b/mm/memblock.c > index 1018e50..2476d15d 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1723,7 +1723,7 @@ void __init memblock_cap_memory_range(phys_addr_t base, phys_addr_t size) > base + size, PHYS_ADDR_MAX); > } > > -void __init memblock_mem_limit_remove_map(phys_addr_t limit) > +void __init memblock_mem_range_remove_map(phys_addr_t base, phys_addr_t limit) > { > phys_addr_t max_addr; > > @@ -1736,7 +1736,12 @@ void __init memblock_mem_limit_remove_map(phys_addr_t limit) > if (max_addr == PHYS_ADDR_MAX) > return; > > - memblock_cap_memory_range(0, max_addr); > + memblock_cap_memory_range(base, max_addr); > +} > + > +void __init memblock_mem_limit_remove_map(phys_addr_t limit) > +{ > + memblock_mem_range_remove_map(0, limit); > } > > static int __init_memblock memblock_search(struct memblock_type *type, phys_addr_t addr) > -- > 2.1.0 > -- Sincerely yours, Mike.