From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EAFAC433F5 for ; Sat, 5 Mar 2022 04:03:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A595A8D0002; Fri, 4 Mar 2022 23:03:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E12A8D0001; Fri, 4 Mar 2022 23:03:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8821C8D0002; Fri, 4 Mar 2022 23:03:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 7AAC28D0001 for ; Fri, 4 Mar 2022 23:03:17 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 5109F80F4A for ; Sat, 5 Mar 2022 04:03:17 +0000 (UTC) X-FDA: 79208987634.01.C451E6E Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf13.hostedemail.com (Postfix) with ESMTP id E7CAC20002 for ; Sat, 5 Mar 2022 04:03:16 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id kx1-20020a17090b228100b001bf2dd26729so2398326pjb.1 for ; Fri, 04 Mar 2022 20:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DNjNmMTRFvb6vnONGhIWC+OgnqkQwzJ4U2IjjfTyD90=; b=MWnFBNqUbnqmMxySEyPpYYnG3q+KcX1+dVgjHzaU5bfUpCng3VkKxrl/jXTMT/AYFG wB840KdN4gx8Wg5CgJIfQSSPdzIsRvMkY9wJ2km+kPpRt46fGlY7c1RcbEhiwygxuMoH LrdU+9+7KDzRiVUGTh6QyQyWgJRZ3CDHrpt+J3U6l2TtFzy+bW+Kl1oA28hRalvKAzsR HHzD9ULUTZJtzX7TxAZt6Dgi/o45EcOtqt2Y7GrPrCp4u7dPp7wdgQRm7J/J8e9IniEW KPaqla2Vh3rAIH4dykXe6cN3FGRCUdXEl4fhTUVTNvlxTNma14OM/Pkhpjf38jLAtjtw RLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DNjNmMTRFvb6vnONGhIWC+OgnqkQwzJ4U2IjjfTyD90=; b=VPzChdthy+H1OdYzbWTFl2LxTZxLPcq5mdJjudveq9CNBtelsqP89/MVf6VGKMycHM tcjpj1CrJu16DQnUVI7fhhMJQv4ysdB0MTY/+9zV2QyUTDFXl7edot1vpWdMcpvFy5tW EzxP5WVtZaOg4D5rhEUxT7kEAEoBXQ52dretELrs/zvxZO6AJLiupQ9oA1qpl3F16tAC w4QtSXUBTUrLSHm5oWsUmesnXnJ0NNFHAjHcX6qmJECdGHpWLqDwCLwijNxb0VzCCxuo AsQYCJUR+fHlPWXxFHh0blRZ69hQtRASv3M43PF4VS3CHfXKfZHyje1MGoSrjeokCc1E X2bA== X-Gm-Message-State: AOAM531C/5Ymrg6LdKpIQSvkBoR0qcCVdZO8FNiAvuSXSn8mwz2B1EDC YLifcxhprEBOgdQnUAmI0h0= X-Google-Smtp-Source: ABdhPJyWbF8QQR9hXYPHj02x5hZat2KesBN01K5DTAtPPg71Q20nhFYTjyR1Oa2SSlfbMTLaLlXitA== X-Received: by 2002:a17:90a:7e8b:b0:1be:ef6c:9797 with SMTP id j11-20020a17090a7e8b00b001beef6c9797mr14102508pjl.183.1646452996098; Fri, 04 Mar 2022 20:03:16 -0800 (PST) Received: from ip-172-31-19-208.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id n34-20020a056a000d6200b004e1ba1016absm7384637pfv.31.2022.03.04.20.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 20:03:15 -0800 (PST) Date: Sat, 5 Mar 2022 04:03:11 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Marco Elver , Matthew WilCox , Roman Gushchin , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] mm/sl[auo]b: move definition of __ksize() to mm/slab.h Message-ID: References: <20220304063427.372145-1-42.hyeyoo@gmail.com> <20220304063427.372145-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E7CAC20002 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MWnFBNqU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Stat-Signature: bgffs876riiay5x7373nkf5bxznwwqj8 X-HE-Tag: 1646452996-656860 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 04, 2022 at 07:29:21PM +0100, Vlastimil Babka wrote: > On 3/4/22 07:34, Hyeonggon Yoo wrote: > > __ksize() is only called by KASAN. Remove export symbol and move > > definition to mm/slab.h as we don't want to grow its callers. > > > > [ willy@infradead.org: Move definition to mm/slab.h and reduce comments ] > > > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Reviewed-by: Vlastimil Babka > Thanks! > > --- a/mm/slab.h > > +++ b/mm/slab.h > > @@ -685,6 +685,8 @@ static inline void free_large_kmalloc(struct folio *folio, void *object) > > } > > #endif /* CONFIG_SLOB */ > > > > +size_t __ksize(const void *objp); > > + > > static inline size_t slab_ksize(const struct kmem_cache *s) > > { > > #ifndef CONFIG_SLUB > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > index 1d2f92e871d2..b126fc7247b9 100644 > > --- a/mm/slab_common.c > > +++ b/mm/slab_common.c > > @@ -1247,13 +1247,7 @@ EXPORT_SYMBOL(kfree_sensitive); > > > > #ifndef CONFIG_SLOB > > /** > > Maybe just /* so it's not even parsed as a kernel-doc anymore? > Oh yes, that would be better. > > - * __ksize -- Uninstrumented ksize. > > - * @objp: pointer to the object > > - * > > - * Unlike ksize(), __ksize() is uninstrumented, and does not provide the same > > - * safety checks as ksize() with KASAN instrumentation enabled. > > - * > > - * Return: size of the actual memory used by @objp in bytes > > + * __ksize -- Uninstrumented ksize. Only called by KASAN. > > */ > > size_t __ksize(const void *object) > > { > > @@ -1269,7 +1263,6 @@ size_t __ksize(const void *object) > > > > return slab_ksize(folio_slab(folio)->slab_cache); > > } > > -EXPORT_SYMBOL(__ksize); > > #endif > > -- Thank you, You are awesome! Hyeonggon :-)