From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD58C433EF for ; Fri, 4 Mar 2022 07:43:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52ABE8D0002; Fri, 4 Mar 2022 02:43:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DA5D8D0001; Fri, 4 Mar 2022 02:43:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C9118D0002; Fri, 4 Mar 2022 02:43:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 2E07C8D0001 for ; Fri, 4 Mar 2022 02:43:33 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id E08886145B for ; Fri, 4 Mar 2022 07:43:32 +0000 (UTC) X-FDA: 79205913864.11.ACABBBE Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf02.hostedemail.com (Postfix) with ESMTP id 094598001A for ; Fri, 4 Mar 2022 07:43:31 +0000 (UTC) Received: from nazgul.tnic (dynamic-002-247-254-208.2.247.pool.telefonica.de [2.247.254.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 75F971EC01CE; Fri, 4 Mar 2022 08:43:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1646379805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wa4qlj2kScoKOUQ36KYA3lgsrDq7guOB8fZmS8g/Qg8=; b=IW0oc0svgti4hQijwpuUIret1pQsGi4VDbH4SBbOxVTSDeLfDBgYrDnLtxYouaWlH+vc4P OVDvTnOraR9H80HGMhLDNW1vLwDMRLLK8EZQ4QImSQvm6Oe4coXv0qK8SyeGDBigoVmH7T GL6AOJQC1jqI/1RfuGCkgL1TVy2JrRQ= Date: Fri, 4 Mar 2022 08:43:30 +0100 From: Borislav Petkov To: Michael Roth Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v11 39/45] x86/sev: Use firmware-validated CPUID for SEV-SNP guests Message-ID: References: <20220224165625.2175020-1-brijesh.singh@amd.com> <20220224165625.2175020-40-brijesh.singh@amd.com> <20220304003157.diqytybw6gpwn5sa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220304003157.diqytybw6gpwn5sa@amd.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 094598001A X-Stat-Signature: 9d1nqfb5whkc4wodktszg74tzowufo7c Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=IW0oc0sv; spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de X-HE-Tag: 1646379811-311829 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 03, 2022 at 06:31:57PM -0600, Michael Roth wrote: > In that case it seems to expect "mce=option1 mce=option2" etc. I could > open-code a parser to handle multiple options like sev=option1,option2 > etc., but wanted to check with you first. Yap, that would make most sense - you want to be able to enable a couple of options without excessive typing. > Also, should I go ahead and introduce struct sev_options now, or > just use a regular bool until more options are added later? struct sev_config { __u64 debug : 1, __reserved : 63; } just like struct mca_config. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette