From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50648C433EF for ; Fri, 4 Mar 2022 12:02:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A70BC8D0002; Fri, 4 Mar 2022 07:02:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1F068D0001; Fri, 4 Mar 2022 07:02:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90EB18D0002; Fri, 4 Mar 2022 07:02:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 8373A8D0001 for ; Fri, 4 Mar 2022 07:02:55 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 40DBE8249980 for ; Fri, 4 Mar 2022 12:02:55 +0000 (UTC) X-FDA: 79206567510.23.1462DED Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf03.hostedemail.com (Postfix) with ESMTP id 524F720018 for ; Fri, 4 Mar 2022 12:02:54 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id o23so7319932pgk.13 for ; Fri, 04 Mar 2022 04:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NzcZgwZFLCCuIJnOuJ1HaowII5peo8NL2C53TxI2HVA=; b=em2FB0rNmaY2N4GJSP4mosWesASMnGcHZrZeumdPkHJrGww65bTu38YdATItGiHQc/ PmLrKaceCTBksdgDmkOFm7PKKx5O6d7uMYrSw3XyxpJTk34EEAQftMuUucjT42Vrz2YA odIfUPn6kZDsTUX/q6A4cnpgkaQb+wKJzscwX5IZ0tLNLMVk4hkI3MH1vVUh3uCW1/jD qkqvmWZE81utQR7lKTw/MqJjCq7EiOoA+Kpz78jADqyt0Uvm0hGjzw+0tNaVgO2XU5Sz +bj6XFrCZRPwHk0/MUdDH/iMKEHeEvnqn/8+x+2TOunE0zudy7QfNNSw6NvCRSJCcFUH FNkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NzcZgwZFLCCuIJnOuJ1HaowII5peo8NL2C53TxI2HVA=; b=wiRiyvN95Z273E76NiJ0tl78Y4ww4RwD++C77CfuohuJlw/BUHST6kegzKeH52hKQN ugGGuzldj7BgRmWvI2V2iqq/WURQz7WkTPBpqRfIqiDOr8Db5NHiSRvgF70N3/7RREU7 5L9aO4Gh4cxOOw9T29Yue9tVazYLA2Ghgnh70p4IcCgBnaNxr86fBQ9+NalikkV+9IZV /vfJXeUNNdqb1TcRC7HIH3D2IsOwoc9Eucv0u11uiYmm9DFVGrB2VKUf5DLQ60jlDHBu PnwszMqiYZxpoXmfN1PmUQFU5BiSJwR+l59/WVZ83VrjqDMJdN/Von4cGg1LRPRowmFt vhEQ== X-Gm-Message-State: AOAM532Bk3T0vznofqHJ6ip6WsfGDKkPcQJuFwdHXq5MufBfwyW/LgUV UXGhHQWqs8kMjjKbO8pTpC8= X-Google-Smtp-Source: ABdhPJxwAUhaRxtOUSm1s6kiBI6LWfM+gF10OYm3swp4ny5IAETwFgi5xIKr8YEoO2/wZQhZoa1iyg== X-Received: by 2002:a05:6a00:885:b0:4f4:17d8:be31 with SMTP id q5-20020a056a00088500b004f417d8be31mr24014481pfj.57.1646395373261; Fri, 04 Mar 2022 04:02:53 -0800 (PST) Received: from ip-172-31-19-208.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id b21-20020a056a000cd500b004e1e0d3ed18sm5788181pfv.2.2022.03.04.04.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 04:02:52 -0800 (PST) Date: Fri, 4 Mar 2022 12:02:48 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Marco Elver Cc: linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Matthew WilCox , Roman Gushchin , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] slab cleanups Message-ID: References: <20220304063427.372145-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: tijnr1m7xt4gsamn8yi9z6da663ctgcq Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=em2FB0rN; spf=pass (imf03.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: 524F720018 X-HE-Tag: 1646395374-383450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 04, 2022 at 12:50:21PM +0100, Marco Elver wrote: > On Fri, 4 Mar 2022 at 07:34, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > > > > Changes from v1: > > Now SLAB passes requests larger than order-1 page > > to page allocator. > > > > Adjusted comments from Matthew, Vlastimil, Rientjes. > > Thank you for feedback! > > > > BTW, I have no idea what __ksize() should return when an object that > > is not allocated from slab is passed. both 0 and folio_size() > > seems wrong to me. > > Didn't we say 0 would be the safer of the two options? > https://lkml.kernel.org/r/0e02416f-ef43-dc8a-9e8e-50ff63dd3c61@suse.cz > Oh sorry, I didn't understand why 0 was safer when I was reading it. Reading again, 0 is safer because kasan does not unpoison for wrongly passed object, right? > > Hello, these are cleanup patches for slab. > > Please consider them for slab-next :) > > > > Any comments will be appreciated. > > Thanks. > > > > Hyeonggon Yoo (5): > > mm/slab: kmalloc: pass requests larger than order-1 page to page > > allocator > > mm/sl[au]b: unify __ksize() > > mm/sl[auo]b: move definition of __ksize() to mm/slab.h > > mm/slub: limit number of node partial slabs only in cache creation > > mm/slub: refactor deactivate_slab() > > > > include/linux/slab.h | 36 ++++++------ > > mm/slab.c | 51 ++++++++--------- > > mm/slab.h | 21 +++++++ > > mm/slab_common.c | 20 +++++++ > > mm/slob.c | 1 - > > mm/slub.c | 130 ++++++++++++------------------------------- > > 6 files changed, 114 insertions(+), 145 deletions(-) > > > > -- > > 2.33.1 > > -- Thank you, You are awesome! Hyeonggon :-)