From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F12CC433F5 for ; Thu, 3 Mar 2022 22:32:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B8238D0002; Thu, 3 Mar 2022 17:32:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9676A8D0001; Thu, 3 Mar 2022 17:32:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830338D0002; Thu, 3 Mar 2022 17:32:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 740438D0001 for ; Thu, 3 Mar 2022 17:32:36 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 49FC9226EB for ; Thu, 3 Mar 2022 22:32:36 +0000 (UTC) X-FDA: 79204525512.01.407A8B3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id A858616000B for ; Thu, 3 Mar 2022 22:32:35 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4B22E218B8; Thu, 3 Mar 2022 22:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1646346754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zAFiVjWnJwrSeWw65bTJP2sI95/1TY2jdAcpRUDQbtM=; b=VXV9PxiWVt8ldki0V+S8Sfj7c687p9Om5DqH1miJtWATf4hOxUPcw4msG056PF7h12uXyy GWj1nCH353Ix4TRBSPj5zbqaiNNKWcpteUC6PB+wNzUtAyrK9wDUgyAz+Iitv1dv9f5T6o RcbOrMACuKsRmhFFczzmGXgR6mCyiAw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 094D013A9C; Thu, 3 Mar 2022 22:32:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rIbpAAJCIWJVOAAAMHmgww (envelope-from ); Thu, 03 Mar 2022 22:32:34 +0000 Date: Thu, 3 Mar 2022 23:32:32 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Randy Dunlap Cc: linux-mm@kvack.org, Igor Zhbanov , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , cgroups@vger.kernel.org Subject: Re: [PATCH 1/2] mm/memcontrol: return 1 from cgroup.memory __setup() handler Message-ID: References: <20220222005811.10672-1-rdunlap@infradead.org> <20220302185300.GA19699@blackbody.suse.cz> <9f8d4ddb-81ce-738a-d1f7-346ff9bf8ebd@infradead.org> <20220303101406.GE10867@blackbody.suse.cz> <5130da56-0f22-8212-0ea3-6ddb8a8f5455@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5130da56-0f22-8212-0ea3-6ddb8a8f5455@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A858616000B X-Stat-Signature: rz9x774cy19x8bkqiys8fptgj45y7r9f Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=VXV9PxiW; spf=pass (imf08.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1646346755-110432 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 03, 2022 at 01:53:03PM -0800, Randy Dunlap wrote: > > Isn't mere presence of the handler sufficient to filter those out? [1] > > What is [1] here? Please ignore, too much editing on my side. > I don't know of any case where "foo=2" should be passed to init if > there is a setup function for "foo=" defined. Good. I was asking because of the following semantics: - absent handler -- pass to init, - returns 0 -- filter out, - returns negative -- filter out, print message. > > (Richer reporting or -EINVAL is by my understanding now a different > > problem.) Regards, Michal