From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA02C433EF for ; Fri, 4 Mar 2022 03:28:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6B588D0002; Thu, 3 Mar 2022 22:28:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F2178D0001; Thu, 3 Mar 2022 22:28:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86C578D0002; Thu, 3 Mar 2022 22:28:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 74E658D0001 for ; Thu, 3 Mar 2022 22:28:42 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 396F124B4E for ; Fri, 4 Mar 2022 03:28:42 +0000 (UTC) X-FDA: 79205271684.09.B3571AB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id CCC6820167 for ; Fri, 4 Mar 2022 03:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646364493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mLBFOql7B4wKhhb9pOztSYHbr/CHgTfUYu0+ylmWE8E=; b=KXJZo3vnIjwr2qLVk1//HdX2JREQBN8cFsALICQqFj3QCsuKZoQdHG1MS7AG1hIOzmdPpM viiq5A5aZpe4wjldxNcN9bbiudmf77ri/DcHT20xqghhokcLaVTjeLboSy8g9Z0Vm4rdp4 D1kyBBhI1BrAeHNWQflqZxQiyeelwiE= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-490-H9YDp9glNFyuxkLJTHgh8A-1; Thu, 03 Mar 2022 21:27:50 -0500 X-MC-Unique: H9YDp9glNFyuxkLJTHgh8A-1 Received: by mail-pg1-f199.google.com with SMTP id x4-20020a63b344000000b00375662f4a7bso3691540pgt.15 for ; Thu, 03 Mar 2022 18:27:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mLBFOql7B4wKhhb9pOztSYHbr/CHgTfUYu0+ylmWE8E=; b=Q0fxGHP9sAah/wmsVzf9fJI4l+5OSoEty6QyF20WmB1spTqaudx2W0jFOOd5B84+vi 5/964NX1CsZy8BKGste8ZXRwwbYWrKPWSU3cLtycY6DoecAeFVd2gWPzsNaYBP85+CPt qpgsnpFQBf1+D6/dOv2ekZEB5k+7IvdFejm98Xw6OkT7wMBvOvvIKuNNveSInMpEyMJN iazvJ6nfYKuVeqEFj5It7nPRbxXxmv79HXqTtVY1I9rmgCrLN23uh7YBKLzFxFkdiNG6 li6ngNL9PiACHMw0phBIqUC/aT/RaoRy5eQstgbyL78YSRibltUocMpzZfZrFVM7/Z73 tI+A== X-Gm-Message-State: AOAM531e4GjS+U3qEMWIfPBZDGUxXfAJI2HDBtte26iTr9TcX70peONd sZlTqJWDjbqXDXhOkZRLq2WWalcVUZy4j0iDgZaTc0RuMFtvN4iThll4CqkQFRmuVjkzTGtlAVo BAADdo1C5V5M= X-Received: by 2002:a05:6a00:174d:b0:4f6:67e3:965 with SMTP id j13-20020a056a00174d00b004f667e30965mr7165495pfc.39.1646360868888; Thu, 03 Mar 2022 18:27:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwOxiLizwmv5cTbElATfDcTmB6Wwjm9bM67BiZPsCDiJ8qqO26cn2/T/7i0rJ95JOg9atjhzA== X-Received: by 2002:a05:6a00:174d:b0:4f6:67e3:965 with SMTP id j13-20020a056a00174d00b004f667e30965mr7165475pfc.39.1646360868608; Thu, 03 Mar 2022 18:27:48 -0800 (PST) Received: from xz-m1.local ([94.177.118.94]) by smtp.gmail.com with ESMTPSA id be6-20020a656e46000000b0036c7c63e915sm3017000pgb.48.2022.03.03.18.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 18:27:48 -0800 (PST) Date: Fri, 4 Mar 2022 10:27:42 +0800 From: Peter Xu To: Nadav Amit Cc: Andrew Morton , Linux-MM , David Hildenbrand , Andrea Arcangeli , Mike Rapoport , Jan Kara Subject: Re: [PATCH v3] userfaultfd: provide unmasked address on page-fault Message-ID: References: <20220226022655.350562-1-namit@vmware.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CCC6820167 X-Stat-Signature: phhkcdeyd565jmguzxmfxsqcomchxsdu X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KXJZo3vn; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf13.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646364493-253957 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 03, 2022 at 07:51:26PM +0000, Nadav Amit wrote: > Peter (et. al), > > I’ll send it in a more orderly fashion later, but let me know if I got > something completely wrong for the man page change: > > [ Thanks as usual; sorry - limited experience changing man pages ] > > -- >8 -- > > From: Nadav Amit > Date: Thu, 3 Mar 2022 19:44:37 +0000 > Subject: [PATCH] ioctl_userfaultfd: add UFFD_FEATURE_EXACT_ADDRESS > > Describe the new UFFD_FEATURE_EXACT_ADDRESS API feature. > > Signed-off-by: Nadav Amit > --- > man2/ioctl_userfaultfd.2 | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > index 504f61d4b..2d065504e 100644 > --- a/man2/ioctl_userfaultfd.2 > +++ b/man2/ioctl_userfaultfd.2 > @@ -214,6 +214,12 @@ memory accesses to the regions registered with userfaultfd. > If this feature bit is set, > .I uffd_msg.pagefault.feat.ptid > will be set to the faulted thread ID for each page-fault message. > +.TP > +.BR UFFD_FEATURE_EXACT_ADDRESS " (since Linux 5.18)" > +If this feature bit is set, > +.I uffd_msg.pagefault.address > +will be set to the exact page-fault address that was reported by the hardware, > +and will not mask the offset within the page. > .PP > The returned > .I ioctls > -- > 2.25.1 Looks good to me, thanks! Acked-by: Peter Xu -- Peter Xu