Re: [PATCH v3] userfaultfd: provide unmasked address on page-fault

[Peter Xu <peterx@redhat.com>]

On Thu, Mar 03, 2022 at 07:51:26PM +0000, Nadav Amit wrote:
> Peter (et. al),
> 
> I’ll send it in a more orderly fashion later, but let me know if I got
> something completely wrong for the man page change:
> 
> [ Thanks as usual; sorry - limited experience changing man pages ]
> 
> -- >8 --
> 
> From: Nadav Amit <namit@vmware.com>
> Date: Thu, 3 Mar 2022 19:44:37 +0000
> Subject: [PATCH] ioctl_userfaultfd: add UFFD_FEATURE_EXACT_ADDRESS
> 
> Describe the new UFFD_FEATURE_EXACT_ADDRESS API feature.
> 
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
>  man2/ioctl_userfaultfd.2 | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
> index 504f61d4b..2d065504e 100644
> --- a/man2/ioctl_userfaultfd.2
> +++ b/man2/ioctl_userfaultfd.2
> @@ -214,6 +214,12 @@ memory accesses to the regions registered with userfaultfd.
>  If this feature bit is set,
>  .I uffd_msg.pagefault.feat.ptid
>  will be set to the faulted thread ID for each page-fault message.
> +.TP
> +.BR UFFD_FEATURE_EXACT_ADDRESS " (since Linux 5.18)"
> +If this feature bit is set,
> +.I uffd_msg.pagefault.address
> +will be set to the exact page-fault address that was reported by the hardware,
> +and will not mask the offset within the page.
>  .PP
>  The returned
>  .I ioctls
> -- 
> 2.25.1

Looks good to me, thanks!

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu