From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEAEC433EF for ; Thu, 3 Mar 2022 11:51:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF3EB8D0002; Thu, 3 Mar 2022 06:51:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA2FC8D0001; Thu, 3 Mar 2022 06:51:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6C2C8D0002; Thu, 3 Mar 2022 06:51:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 983C58D0001 for ; Thu, 3 Mar 2022 06:51:29 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 5EBCF622FE for ; Thu, 3 Mar 2022 11:51:29 +0000 (UTC) X-FDA: 79202909898.11.171FEF2 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf31.hostedemail.com (Postfix) with ESMTP id DEA5D2000A for ; Thu, 3 Mar 2022 11:51:22 +0000 (UTC) Received: from nazgul.tnic (nat0.nue.suse.com [IPv6:2001:67c:2178:4000::1111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 237E61EC032C; Thu, 3 Mar 2022 12:51:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1646308277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=4etORIg2Q6KJ92tEY8v0D9IqX+zqC98LN3nMR0UBOqA=; b=dWOeNnBF7RaxfscWLq+DFbNU8NUKF85I2GUUohS4muRNYSW163/4jCh3x+ITc+ckdPvo25 IE2nqZFAlPScH8tklRX9QRDxdTDsBSMRVehoLhn7MH62b6JEmH3JS66iXecq7agtZpVVFC SWiu4T172cJ4CdTwu49FO/VBRl8WN1M= Date: Thu, 3 Mar 2022 12:51:20 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v11 39/45] x86/sev: Use firmware-validated CPUID for SEV-SNP guests Message-ID: References: <20220224165625.2175020-1-brijesh.singh@amd.com> <20220224165625.2175020-40-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220224165625.2175020-40-brijesh.singh@amd.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DEA5D2000A X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=dWOeNnBF; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=pass (imf31.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de X-Stat-Signature: jcod9yewro5e7t69z5gk147i6746y875 X-HE-Tag: 1646308282-207765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 10:56:19AM -0600, Brijesh Singh wrote: > Also add an "sev_debug" kernel command-line parameter that will be used > (initially) to dump the CPUID table for debugging/analysis. No, not "sev_debug" - "sev=debug". I'm pretty sure there will be need for other SEV-specific cmdline options so this thing should be a set, i.e., "sev=(option1,option2?,option3?,...)" etc. See mcheck_enable() and the comment above it for an example. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette