From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2F4C433F5 for ; Mon, 14 Mar 2022 16:17:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D82F56B0071; Mon, 14 Mar 2022 12:17:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0B6B8D0002; Mon, 14 Mar 2022 12:17:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD018D0001; Mon, 14 Mar 2022 12:17:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id A36DA6B0071 for ; Mon, 14 Mar 2022 12:17:51 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 673B89F5C1 for ; Mon, 14 Mar 2022 16:17:51 +0000 (UTC) X-FDA: 79243497942.17.1814D76 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id F06B9180012 for ; Mon, 14 Mar 2022 16:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dwLf6RzOeFuliLX0ooOtLy5ua6UBRGxTFPEUWQAzNJQ=; b=Pr7f3PvG+NbM0IYBxGkd1YzIir jdNMYdBSaaM0cbshTydJt2sFfwwx+ieJB3mXnoqvDQX+4zE35YjCF4l9qKUyBFyO7OVsRceSUIaBc x33Uhn4HzmuZ6LUdngR6jn1/s0hnAoHp9n8brEc80WGbNPVP5VhZwjWtgGOz0f0VyYyE4pndFFJiw 0po3+c4818Zqf3nNx96XSUL5GWX1NlO0DEQrjLm2jKVC3jb2tKgjQzB3Qlyx/BMCNqRw1EfE3oUwA zchMrCY7GErAryhJ3RWjZ/gTGJpP1XH8T6gVpcL5RLZHatS5EaHC5J0NRhh6Z6U+wZFiKSnQc4//Z NGnlmKtQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTnOF-004CZY-WC; Mon, 14 Mar 2022 16:17:48 +0000 Date: Mon, 14 Mar 2022 16:17:47 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, hughd@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mlock: remove unneeded start >= vma->vm_end check Message-ID: References: <20220314153223.53753-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220314153223.53753-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F06B9180012 X-Stat-Signature: e3tsnsczufdud8mxrzm96ws55kdrm73t Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Pr7f3PvG; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-HE-Tag: 1647274670-827757 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 14, 2022 at 11:32:23PM +0800, Miaohe Lin wrote: > If find_vma returns a vma, it must satisfies that start < vma->vm_end. > Since vma list is sorted in the ascending order, so we will never see > start >= vma->vm_end here. Remove this unneeded check. faulty logic; vm_start + len might wrap.