* [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check
@ 2022-02-24 11:59 Miaohe Lin
2022-02-24 19:23 ` David Rientjes
2022-02-28 15:11 ` Michal Hocko
0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2022-02-24 11:59 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe
oom_cpuset_eligible is always called when !is_memcg_oom. Remove this
unnecessary check.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/oom_kill.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 9fea6d3c1ec7..c70a4330e548 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -122,9 +122,6 @@ static bool oom_cpuset_eligible(struct task_struct *start,
bool ret = false;
const nodemask_t *mask = oc->nodemask;
- if (is_memcg_oom(oc))
- return true;
-
rcu_read_lock();
for_each_thread(start, tsk) {
if (mask) {
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check
2022-02-24 11:59 [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check Miaohe Lin
@ 2022-02-24 19:23 ` David Rientjes
2022-02-28 15:11 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2022-02-24 19:23 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel
On Thu, 24 Feb 2022, Miaohe Lin wrote:
> oom_cpuset_eligible is always called when !is_memcg_oom. Remove this
> unnecessary check.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: David Rientjes <rientjes@google.com>
This keeps oom_cpuset_eligible() only in the nodemask eligibility business
and memcg criteria remains isolated in its own function.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check
2022-02-24 11:59 [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check Miaohe Lin
2022-02-24 19:23 ` David Rientjes
@ 2022-02-28 15:11 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2022-02-28 15:11 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel
On Thu 24-02-22 19:59:33, Miaohe Lin wrote:
> oom_cpuset_eligible is always called when !is_memcg_oom. Remove this
> unnecessary check.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> mm/oom_kill.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 9fea6d3c1ec7..c70a4330e548 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -122,9 +122,6 @@ static bool oom_cpuset_eligible(struct task_struct *start,
> bool ret = false;
> const nodemask_t *mask = oc->nodemask;
>
> - if (is_memcg_oom(oc))
> - return true;
> -
> rcu_read_lock();
> for_each_thread(start, tsk) {
> if (mask) {
> --
> 2.23.0
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-28 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 11:59 [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check Miaohe Lin
2022-02-24 19:23 ` David Rientjes
2022-02-28 15:11 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox