From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE8BC4332F for ; Mon, 28 Feb 2022 13:41:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36EA88D0002; Mon, 28 Feb 2022 08:41:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31E268D0001; Mon, 28 Feb 2022 08:41:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20DBD8D0002; Mon, 28 Feb 2022 08:41:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 129118D0001 for ; Mon, 28 Feb 2022 08:41:21 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BE37E8249980 for ; Mon, 28 Feb 2022 13:41:20 +0000 (UTC) X-FDA: 79192300320.27.E9A73F3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id E38FA1C000D for ; Mon, 28 Feb 2022 13:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sQtTKWJmjpY/ri7IYv25rVo1Rbt+2LizJ2pbjnDNo3Q=; b=cvw+XDmD0ZgdE5aLkvbVfFMS6l c/Ie3dW6zQ7w9oV5vT+5yQHgXAajqWaWo5YqvDupVLpOpqcHFv2KYVXXcUjUTm31WXDHpVC49VLEO HMz3fciGM/DoaYcOQ5QrnqTVm0hUXLqLu44j+stFj862JqqkA3DhO4HeXR9HK+WUkEd+9bAxvZ3yR PYNA0mUA363VIX9cdRz1cXyYAcnIe5UJmpY7EbWKjj/CScoJY04MM5ktWL1zWJoEQ90pqe14wU0Uv jXAYhhKNqSORA8Dgw25HMlvXhmlUBU0mLmFnFFt2hwaEone8bwzZpMG9y+HOuBWnyAQw64xGzl6qD UIz2MqoA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOgH0-00CdxV-6a; Mon, 28 Feb 2022 13:41:10 +0000 Date: Mon, 28 Feb 2022 05:41:10 -0800 From: Christoph Hellwig To: David Howells Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org, willy@infradead.org, kirill@shutemov.name, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Export PageHeadHuge() Message-ID: References: <2494562.1646054576@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2494562.1646054576@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E38FA1C000D X-Stat-Signature: x6nkqm57gsuzq4oh6opsr9z4nfw41pur Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=cvw+XDmD; spf=none (imf20.hostedemail.com: domain of BATV+72096dbc355c8c690838+6763+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+72096dbc355c8c690838+6763+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-HE-Tag: 1646055678-256200 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 28, 2022 at 01:22:56PM +0000, David Howells wrote: > > Export PageHeadHuge() - it's used by folio_test_hugetlb() and thence by > such as folio_file_page() and folio_contains(). Matthew suggested I use > the first of those instead of doing the same calculation manually - but > I can't call it from a module. > > Kirill suggested rearranging things to put it in a header, but that > introduces header dependencies because of where constants are defined. > > Signed-off-by: David Howells > cc: willy@infradead.org > Link: https://lore.kernel.org/r/163707085314.3221130.14783857863702203440.stgit@warthog.procyon.org.uk/ > > --- > mm/hugetlb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 61895cc01d09..5768df43b05c 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1854,6 +1854,7 @@ int PageHeadHuge(struct page *page_head) > > return page_head[1].compound_dtor == HUGETLB_PAGE_DTOR; > } > +EXPORT_SYMBOL(PageHeadHuge); EXPORT_SYMBOL_GPL for anything hugepage related, please.