From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C4D5C433EF for ; Mon, 28 Feb 2022 11:08:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D683E8D0002; Mon, 28 Feb 2022 06:08:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D17F18D0001; Mon, 28 Feb 2022 06:08:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05F88D0002; Mon, 28 Feb 2022 06:08:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id B12058D0001 for ; Mon, 28 Feb 2022 06:08:43 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 71B9B23282 for ; Mon, 28 Feb 2022 11:08:43 +0000 (UTC) X-FDA: 79191915726.12.4D45343 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf27.hostedemail.com (Postfix) with ESMTP id CC20340012 for ; Mon, 28 Feb 2022 11:08:42 +0000 (UTC) Date: Mon, 28 Feb 2022 12:08:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1646046521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mnquIb5GSTn+DLQ3cN/hm1a1j7DJpMevzJiSlMx6tcs=; b=WysKBJ9IkEvnBYFFSQ0+2L3p3tRyVyTwRhP6bOG1UgOvwRUZLIXng9nE+McGX2jnrVCIVN +Q3RyRL/+zwL3QpXWF9rUifwBbrXJdav9I2pJLLggORAJqRnsQ7cpl4LRmSNeyv6W1jtd2 vhVhhE/QnDDGatySQs6sj+1BjqPw1G+MiFvZi8QGij/jE5xdNf4iDdNjJySd2J5A+YGtAl NrMP6411jsvyhrJQTIx6M0IXWHfpOO0cKZh4rmugZec5j6bE6lKeLgxwzHdNuolu+WHxqH KqoZkdm/8Ew6gxGghv25swpDTOVVrrjNtWKTRO6I0/gJI4jT/d2i4njP/b0YNw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1646046521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mnquIb5GSTn+DLQ3cN/hm1a1j7DJpMevzJiSlMx6tcs=; b=lxhZsiARSZXEKvThVxCqZ4Ip9YPS/onIOC4WRpn/SuPwr03p1aB4YQJG2JKj8+3aqTk1TV S18EBJ4A1gsYqAAA== From: Sebastian Andrzej Siewior To: Michal Hocko Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Michal =?utf-8?Q?Koutn=C3=BD?= , Peter Zijlstra , Thomas Gleixner , Vladimir Davydov , Waiman Long , Roman Gushchin Subject: Re: [PATCH v5 3/6] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed. Message-ID: References: <20220226204144.1008339-1-bigeasy@linutronix.de> <20220226204144.1008339-4-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CC20340012 X-Stat-Signature: k55esosfkuomepj9b61edt3qsu4dacfj Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=WysKBJ9I; dkim=pass header.d=linutronix.de header.s=2020e header.b=lxhZsiAR; spf=pass (imf27.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-HE-Tag: 1646046522-862058 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-02-28 09:05:45 [+0100], Michal Hocko wrote: > Acked-by: Michal Hocko > > TBH I am not a fan of the counter special casing for the debugging > enabled warnings but I do not feel strong enough to push you trhough an > additional version round. do you want to get rid of the warnings completely? Since we had the check in memcg_stats_lock() it kinda felt useful to add something in __memcg_stats_lock() case, too. > Thanks! Sebastian