From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4ABEC433F5 for ; Mon, 28 Feb 2022 12:18:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26DCF8D0002; Mon, 28 Feb 2022 07:18:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21C3D8D0001; Mon, 28 Feb 2022 07:18:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10BD38D0002; Mon, 28 Feb 2022 07:18:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id F39858D0001 for ; Mon, 28 Feb 2022 07:18:09 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BBBFC233FF for ; Mon, 28 Feb 2022 12:18:09 +0000 (UTC) X-FDA: 79192090698.02.AF24D0C Received: from mx.treblig.org (mx.treblig.org [46.43.15.161]) by imf27.hostedemail.com (Postfix) with ESMTP id 062CE40003 for ; Mon, 28 Feb 2022 12:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=KXZFUJH9IMivzQ4dLa//v1ZDi0JJT/uywv36ICj5Y9g=; b=lcX1dXwH45zc5S/ujByc+8polV 2wVY1WEVAM2fPfI4zPWRCs2Xv0uZumsu7N5e7KnSWfgaLVA7HUMJV3J8evpYuZVzJS+rDwjuTwxNz 2RSb1peVyJmmxy3b6dTCsEzAMnmxfu3eT8ZUQQZH7qIFsCbx6DTS3joA1nDnjeHZ1JqTtuNcMv+oz 9F2TKAhFqfn2BVdhMbLiRJjPLutAMK6EkL0GdO1e30om1Z7XfLNighHUghScv6EZq9h5i2lgDxfsD SnC0r1vzkPDMe4wT/KjMRwmAj1bAHmsqyUrJ+SQ9wV+vYLEd2sbpIaLrhrZr2Pll90EOmHv6hu21x 3K56qZmQ==; Received: from dg by mx.treblig.org with local (Exim 4.94.2) (envelope-from ) id 1nOeyc-000qHH-Di; Mon, 28 Feb 2022 12:18:06 +0000 Date: Mon, 28 Feb 2022 12:18:06 +0000 From: "Dr. David Alan Gilbert" To: Andrew Morton Cc: pasha.tatashin@soleen.com, songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Use strtobool for param parsing Message-ID: References: <20220227181038.126926-1-linux@treblig.org> <20220227135128.3f5aabca43c7a33acea91cc8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20220227135128.3f5aabca43c7a33acea91cc8@linux-foundation.org> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/5.10.0-9-amd64 (x86_64) X-Uptime: 12:17:30 up 112 days, 21:50, 1 user, load average: 0.06, 0.01, 0.00 User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 062CE40003 X-Stat-Signature: nzzwhotpect3xr4bq9xisdmyw3enasyp Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=treblig.org header.s=bytemarkmx header.b=lcX1dXwH; dmarc=none; spf=pass (imf27.hostedemail.com: domain of dg@treblig.org designates 46.43.15.161 as permitted sender) smtp.mailfrom=dg@treblig.org X-HE-Tag: 1646050688-428211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Andrew Morton (akpm@linux-foundation.org) wrote: > On Sun, 27 Feb 2022 18:10:39 +0000 "Dr. David Alan Gilbert" wrote: > > > Use strtobool rather than open coding "on" and "off" parsing in > > mm/hugetlb_vmemmap.c and mm/page_table_check.c. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > mm/hugetlb_vmemmap.c | 12 +----------- > > mm/page_table_check.c | 10 +--------- > > 2 files changed, 2 insertions(+), 20 deletions(-) > > > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > > index c540c21e26f5b..919411386e547 100644 > > --- a/mm/hugetlb_vmemmap.c > > +++ b/mm/hugetlb_vmemmap.c > > @@ -192,17 +192,7 @@ static int __init early_hugetlb_free_vmemmap_param(char *buf) > > return 0; > > } > > > > - if (!buf) > > - return -EINVAL; > > - > > - if (!strcmp(buf, "on")) > > - hugetlb_free_vmemmap_enabled = true; > > - else if (!strcmp(buf, "off")) > > - hugetlb_free_vmemmap_enabled = false; > > - else > > - return -EINVAL; > > - > > - return 0; > > + return strtobool(buf, &hugetlb_free_vmemmap_enabled); > > } > > early_param("hugetlb_free_vmemmap", early_hugetlb_free_vmemmap_param); > > This part falls afoul of the changes in > https://lkml.kernel.org/r/20211101031651.75851-3-songmuchun@bytedance.com Hmm, yes that's quite different. > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > > index 3763bd077861a..2458281bff893 100644 > > --- a/mm/page_table_check.c > > +++ b/mm/page_table_check.c > > @@ -23,15 +23,7 @@ EXPORT_SYMBOL(page_table_check_disabled); > > > > static int __init early_page_table_check_param(char *buf) > > { > > - if (!buf) > > - return -EINVAL; > > - > > - if (strcmp(buf, "on") == 0) > > - __page_table_check_enabled = true; > > - else if (strcmp(buf, "off") == 0) > > - __page_table_check_enabled = false; > > - > > - return 0; > > + return strtobool(buf, &__page_table_check_enabled); > > } > > But this works OK. Thanks for taking it. Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/