From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC47EC433F5 for ; Sun, 27 Feb 2022 22:15:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57F2D8D0002; Sun, 27 Feb 2022 17:15:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52EE28D0001; Sun, 27 Feb 2022 17:15:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6758D0002; Sun, 27 Feb 2022 17:15:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 308868D0001 for ; Sun, 27 Feb 2022 17:15:33 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DE69D9A7FF for ; Sun, 27 Feb 2022 22:15:32 +0000 (UTC) X-FDA: 79189967304.18.2AA7B6E Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [142.44.231.140]) by imf18.hostedemail.com (Postfix) with ESMTP id 73CE01C0004 for ; Sun, 27 Feb 2022 22:15:32 +0000 (UTC) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nORoy-005Wb1-JX; Sun, 27 Feb 2022 22:15:16 +0000 Date: Sun, 27 Feb 2022 22:15:16 +0000 From: Al Viro To: jhubbard.send.patches@gmail.com Cc: Jens Axboe , Jan Kara , Christoph Hellwig , Dave Chinner , "Darrick J . Wong" , Theodore Ts'o , Miklos Szeredi , Andrew Morton , Chaitanya Kulkarni , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, LKML , John Hubbard Subject: Re: [PATCH 3/6] block, fs: assert that key paths use iovecs, and nothing else Message-ID: References: <20220227093434.2889464-1-jhubbard@nvidia.com> <20220227093434.2889464-4-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220227093434.2889464-4-jhubbard@nvidia.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 73CE01C0004 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=none (imf18.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 142.44.231.140) smtp.mailfrom=viro@ftp.linux.org.uk X-Stat-Signature: o39anhcqozyo4fca5iw3mrpjrh5df8ch X-HE-Tag: 1646000132-300691 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 27, 2022 at 01:34:31AM -0800, jhubbard.send.patches@gmail.com wrote: > From: John Hubbard > > Upcoming changes to Direct IO will change it from acquiring pages via > get_user_pages_fast(), to calling pin_user_pages_fast() instead. > > Place a few assertions at key points, that the pages are IOVEC (user > pages), to enforce the assumptions that there are no kernel or pipe or > other odd variations being passed. Umm... And what should happen when O_DIRECT file gets passed to splice()?