From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE56C433F5 for ; Sat, 26 Feb 2022 21:02:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 353918D000B; Sat, 26 Feb 2022 16:02:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FCB58D0007; Sat, 26 Feb 2022 16:02:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EB658D000B; Sat, 26 Feb 2022 16:02:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 102BE8D0007 for ; Sat, 26 Feb 2022 16:02:26 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C7F04998DC for ; Sat, 26 Feb 2022 21:02:25 +0000 (UTC) X-FDA: 79186154250.30.FB2593D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 4CDDE120002 for ; Sat, 26 Feb 2022 21:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t5PvKUiCfOMquPumfQ4cEUgcoR3Wsv7oMQVd0HhO0Zo=; b=gtNP4G6fJqE4QOtsMvUMIVFpQ4 usPnT7I8lr5qMEgoySSAWt79IYauedv87xchUhNtpl7pnUuuRmvckbPV6Jrh5QQRePDS6sPnrEQDd mLQ0Ey83QSIJDK7LZAYz8RaD9Ty3Uk4YPD8g08lRJITopv9NFbKS0T6ivFF2JXpzjxWqLKHWfLMs7 /1pUHclLHba1zIqBZlA3gQ5Fdj504mt++KNl0uh9fqrQ9NvJbk0RXdsU+cxFtTCjnPBSHCngUnrxJ dos+hBJALOqBjdOz1d/nnI/Uul/HHo8YsphtGDRkybBB1eyTqR3HR5r/4/hbB0g5TVXmt2v3P+8gM 8tVWXt+A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO4Cp-008XqG-Id; Sat, 26 Feb 2022 21:02:19 +0000 Date: Sat, 26 Feb 2022 13:02:19 -0800 From: Luis Chamberlain To: tangmeng Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nizhen@uniontech.com, zhanglianjie@uniontech.com, nixiaoming@huawei.com Subject: Re: [PATCH v2 10/11] fs/drop_caches: move drop_caches sysctls to its own file Message-ID: References: <20220221061018.10472-1-tangmeng@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221061018.10472-1-tangmeng@uniontech.com> X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: rde1a8jijba7ycakzs914hmw7tie6ad4 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=gtNP4G6f; spf=none (imf29.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Queue-Id: 4CDDE120002 X-HE-Tag: 1645909345-303935 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001408, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 21, 2022 at 02:10:18PM +0800, tangmeng wrote: > kernel/sysctl.c is a kitchen sink where everyone leaves their dirty > dishes, this makes it very difficult to maintain. > > To help with this maintenance let's start by moving sysctls to places > where they actually belong. The proc sysctl maintainers do not want to > know what sysctl knobs you wish to add for your own piece of code, we > just care about the core logic. > > All filesystem syctls now get reviewed by fs folks. This commit > follows the commit of fs, move the drop_caches sysctls to its own file, > fs/drop_caches.c. > > Signed-off-by: tangmeng Thanks but please send a v3 including all the other patches as well and collecting the Reviewed/Acked-bys, etc. This can be sent *after* your v3 of the optimization work. Luis