From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66C6C433EF for ; Sat, 26 Feb 2022 21:01:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 486008D000A; Sat, 26 Feb 2022 16:01:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 436558D0007; Sat, 26 Feb 2022 16:01:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 327E28D000A; Sat, 26 Feb 2022 16:01:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 203328D0007 for ; Sat, 26 Feb 2022 16:01:06 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CBFA99A80D for ; Sat, 26 Feb 2022 21:01:05 +0000 (UTC) X-FDA: 79186150890.18.9967D03 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 36BC518000C for ; Sat, 26 Feb 2022 21:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=msxU2UfcVFrwCj3eU5XFZoVOe7HH+NdjfV+cwoL/Fik=; b=yfQKckeHAJUkzcec9GpbN5u7v5 tt7t+WkvONdXeNDMT9gecLftrxF7SgByNdnwaiPKnHsbsvgxjdYak+WeNFloAOLrGcpUe8nuaz/Ur eo3Kc2A3i15qlSLEByZ6uW5+OWy0H2QqMgWJNLJ6D5glFLloHSGkYDrW2aVBDXKZC9CSYpNmqIyjB JrKzp6SQtMgaDnGLjrD6AMIRjbWqxTpOIyNeMsvLMviz+OI9FF7FgfO/PWimm1Ezng3aWoUBxsmtG rRABOwL3FQU/4IS8uQ24Lbj8rpoL6y4m9BrG9jwGRmqgs5JdBRQSDAa6IjGfGKR4K3tZL4vNov1Sx XQPBj4gw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO4BR-008Xjj-IV; Sat, 26 Feb 2022 21:00:53 +0000 Date: Sat, 26 Feb 2022 13:00:53 -0800 From: Luis Chamberlain To: tangmeng Cc: Matthew Wilcox , viro@zeniv.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nizhen@uniontech.com, zhanglianjie@uniontech.com, nixiaoming@huawei.com, sujiaxun@uniontech.com Subject: Re: [PATCH 10/11] fs/drop_caches: move drop_caches sysctls to its own file Message-ID: References: <20220220060626.15885-1-tangmeng@uniontech.com> <8940d534-d6e5-0642-f145-67a323eb8092@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8940d534-d6e5-0642-f145-67a323eb8092@uniontech.com> X-Rspamd-Queue-Id: 36BC518000C X-Stat-Signature: 1aadbba1agyq769e8gumsnzfb1hs3bi5 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yfQKckeH; spf=none (imf16.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1645909264-140613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 23, 2022 at 05:51:33PM +0800, tangmeng wrote: > On 2022/2/23 08:39, Luis Chamberlain wrote: > > > > Since you are following up on more changes, can you work on this? > > Brownie points if you show size results to refelct no size difference > > based on a new build with an example new user. > > > > I'm going work on this, but I think it may take some times to get it done. Thanks and good stuff! Can you please then make that the focus of your first set of patches, and then respin this series by collecting all ACKs, Reviwed-bys? Yes please send a new v3 series for it. While at it please Cc the other folks doing sysctls changes so they are aware of this. Thanks! Luis