From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECAFC433EF for ; Sat, 26 Feb 2022 10:41:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51FEC8D0002; Sat, 26 Feb 2022 05:41:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CEBB8D0001; Sat, 26 Feb 2022 05:41:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BE458D0002; Sat, 26 Feb 2022 05:41:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 2E0108D0001 for ; Sat, 26 Feb 2022 05:41:23 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D8CFD8249980 for ; Sat, 26 Feb 2022 10:41:22 +0000 (UTC) X-FDA: 79184589204.26.0984319 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf25.hostedemail.com (Postfix) with ESMTP id 6DFACA0007 for ; Sat, 26 Feb 2022 10:41:22 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id z4so6976134pgh.12 for ; Sat, 26 Feb 2022 02:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mjKhWjMPgXbeTa11qHZqOVCkCLpM7JLImgJi+vBEKC8=; b=fmng/ke0W2wco9Dkgh/fE1Mc4KET/2dyix7KRg3kGVQKCHDTQfcvyAPerYvGon36po LeWBx2bpFD6t6bWZsEw0JlquCY8SljLS47eIm8IZMJmo9Je9tRCy9yIqns9uDYeKp8+A tI3vv9hWYPhbqQcIzLc2+U/IeIbJw6rwms0HPWWh+tVDSNYE+X5VsJ8hZ3ebh2GXd3pg QJQFRvil9q6Gw2qATURb9ZHyrR4nbSFU0fbr3KgUFCEZ1UDwXD65smcRs0AvjamfTjOJ 995OvEwV0pjf7Fwto5W3AFSXTQCJorRELw8KJa0i9Hr4R9KNeCOAQEfNUo7kaknRT7CW AU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mjKhWjMPgXbeTa11qHZqOVCkCLpM7JLImgJi+vBEKC8=; b=lYQ6poJkzBKU56W9EJ4+RhREgSDjRn1PnMQXm3GtkOIZsKfbvncstc3Dc1MzjCWxVq mX9lX6XS2FtNJHRBqQq0tH4n4oR8elijjtQfp1w4hvJauLwCMnjGF/Q0/Gc+NAdiK12J 4cHbWmlhtwJNDKzeXeLHjJs1Ay5hyI+erLp32OtPOYVBNGtW46SIOOAbkRktWNsLDHep AIXl/Hf6OLPfAxOO1axYFC4aDmDZBeuvKJsBWoi2c5vvoWsd9ArxhbeVnLSeqrDfqUNT GEkVrg4XOpDo6h7WohUcHvCy7k2RSexYa0GDWJE7fEW5foa1nzgU8GezKBC02h6rZtgX ORnA== X-Gm-Message-State: AOAM532vH8XY2igRTSkl/448rZd00coSYxEjx8Oo1xx0z1ITncjbhppK wZ8u+xyKDM6XAWiM+IOBPmU= X-Google-Smtp-Source: ABdhPJwkz7N4NjXwnG7ZBWanGBQgQQx6wh8pZy+BiHHzDDCntbMTgl4OsBqWhmBEnJbB8Fm0tus8xQ== X-Received: by 2002:a63:64a:0:b0:36c:6d40:5688 with SMTP id 71-20020a63064a000000b0036c6d405688mr9731007pgg.554.1645872081193; Sat, 26 Feb 2022 02:41:21 -0800 (PST) Received: from ip-172-31-19-208.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id g9-20020a056a0023c900b004e10365c47dsm6552162pfc.192.2022.02.26.02.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 02:41:20 -0800 (PST) Date: Sat, 26 Feb 2022 10:41:16 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Glitta , Faiyaz Mohammed Subject: Re: [PATCH 1/5] mm/slub: move struct track init out of set_track() Message-ID: References: <20220225180318.20594-1-vbabka@suse.cz> <20220225180318.20594-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225180318.20594-2-vbabka@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6DFACA0007 X-Stat-Signature: r6ts8rcipf1qgdcqxb95irqqypnes39x Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="fmng/ke0"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-HE-Tag: 1645872082-701202 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 25, 2022 at 07:03:14PM +0100, Vlastimil Babka wrote: > set_track() either zeroes out the struct track or fills it, depending on > the addr parameter. This is unnecessary as there's only one place that > calls it for the initialization - init_tracking(). We can simply do the > zeroing there, with a single memset() that covers both TRACK_ALLOC and > TRACK_FREE as they are adjacent. > > Signed-off-by: Vlastimil Babka > --- > mm/slub.c | 32 +++++++++++++++----------------- > 1 file changed, 15 insertions(+), 17 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 261474092e43..1fc451f4fe62 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -729,34 +729,32 @@ static void set_track(struct kmem_cache *s, void *object, > { > struct track *p = get_track(s, object, alloc); > > - if (addr) { > #ifdef CONFIG_STACKTRACE > - unsigned int nr_entries; > + unsigned int nr_entries; > > - metadata_access_enable(); > - nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > - TRACK_ADDRS_COUNT, 3); > - metadata_access_disable(); > + metadata_access_enable(); > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > + TRACK_ADDRS_COUNT, 3); > + metadata_access_disable(); > > - if (nr_entries < TRACK_ADDRS_COUNT) > - p->addrs[nr_entries] = 0; > + if (nr_entries < TRACK_ADDRS_COUNT) > + p->addrs[nr_entries] = 0; > #endif > - p->addr = addr; > - p->cpu = smp_processor_id(); > - p->pid = current->pid; > - p->when = jiffies; > - } else { > - memset(p, 0, sizeof(struct track)); > - } > + p->addr = addr; > + p->cpu = smp_processor_id(); > + p->pid = current->pid; > + p->when = jiffies; > } > > static void init_tracking(struct kmem_cache *s, void *object) > { > + struct track *p; > + > if (!(s->flags & SLAB_STORE_USER)) > return; > > - set_track(s, object, TRACK_FREE, 0UL); > - set_track(s, object, TRACK_ALLOC, 0UL); > + p = get_track(s, object, TRACK_ALLOC); > + memset(p, 0, 2*sizeof(struct track)); > } > Looks good. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> And works nicely. Tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > static void print_track(const char *s, struct track *t, unsigned long pr_time) > -- > 2.35.1 > > -- Thank you, You are awesome! Hyeonggon :-)