From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F4EC433F5 for ; Sat, 26 Feb 2022 07:19:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B37458D0002; Sat, 26 Feb 2022 02:19:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE5D08D0001; Sat, 26 Feb 2022 02:19:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D4ED8D0002; Sat, 26 Feb 2022 02:19:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 8D42F8D0001 for ; Sat, 26 Feb 2022 02:19:22 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 382EF180972D7 for ; Sat, 26 Feb 2022 07:19:22 +0000 (UTC) X-FDA: 79184080164.24.9D41FB5 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf05.hostedemail.com (Postfix) with ESMTP id A8C81100004 for ; Sat, 26 Feb 2022 07:19:21 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id d187so6607967pfa.10 for ; Fri, 25 Feb 2022 23:19:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w/nWriioWhTCDbXhgq6kII6jQkdhme4v3WIf5BYW8Qw=; b=Q5YTpZthtvysfBrdzc4noBJ4ma3kSXbtSS7u4D7zltlumAqiWbRQLdRrUaFfbnDgWV aT6ci8xd5ZSFJTGxJPXz52yXwg6Bquy6zbSkU59zTFo1VdGLr7HwNTwRrNqnFz7FlxU/ kW+9ryL+a2zsurlxh52elWSk4oATd49/abO3+H1uHFuF+GIdK34bz6av1HHbejyJPnnZ 9o+ldoQ/AGtOk/CAi5bw3P+Fq08aAxq+Z19Q/WIUI/CuiATJfaT1l1aDd5xm7PE4p0UD PRp7cTR+m3p9raxPGIzccwSsZkNkzt84APNv/b6T9mp89HDuzMDI+kSp1Sfn6kQlInnS kkjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w/nWriioWhTCDbXhgq6kII6jQkdhme4v3WIf5BYW8Qw=; b=VWWS7s1DsQZLZzDQVlPtr7WBJwm24ix2VjPEFGd/MZuMsz3nE56hM7icViOX03KcUW aqC4XKh8HekweJrFB9vGgXZvwqIhv7DvONoxEQwpCIG2QSU4Dru4+ysgSfWyERrHC0Eg 5tTaw4ZRQf/u0xgl9SdUgD+CQypV+vpNjLROnBbSkdRF1CtlN7UlAY2e7OIC9dd12ZNa 0CgEnwK/8B/eN/bUIyIk+Wp0x6jCRZnMM5DgPK4KoHTYR4SmiqdIbyiOZSCQ/Jv08YnA XD5Qp3OiYNvIVweK5gXmJrZaHDfIqvk+JvgoYUVTQOYzYgttGAhYvwLs/ZLrir+BLVlD PP/A== X-Gm-Message-State: AOAM533gpcWvM4sjRYJ8vAeLkNPw5brck1zijFsqnxW+r/ctrshisnHl xiogSnWFrQSZ7Y30PhX4yvA= X-Google-Smtp-Source: ABdhPJxbGmLtUJ+pAMwAQGsx9xQgcS6vz8B1z1/Fcn+J1vyx7yy603Q5p0jypvIbXgnMXtHaCMuDnw== X-Received: by 2002:a63:7d5:0:b0:374:5575:8773 with SMTP id 204-20020a6307d5000000b0037455758773mr9166160pgh.160.1645859960339; Fri, 25 Feb 2022 23:19:20 -0800 (PST) Received: from ip-172-31-19-208.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id e2-20020a056a00162200b004e0a8002697sm5347933pfc.123.2022.02.25.23.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 23:19:19 -0800 (PST) Date: Sat, 26 Feb 2022 07:19:14 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Glitta , Faiyaz Mohammed , Jonathan Corbet , Randy Dunlap Subject: Re: [PATCH 0/5] SLUB debugfs improvements based on stackdepot Message-ID: References: <20220225180318.20594-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225180318.20594-1-vbabka@suse.cz> X-Rspamd-Queue-Id: A8C81100004 X-Stat-Signature: syqszr19m64qeomc57io3q38cttge89r X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q5YTpZth; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1645859961-381303 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 25, 2022 at 07:03:13PM +0100, Vlastimil Babka wrote: > Hi, > > this series combines and revives patches from Oliver's last year > bachelor thesis (where I was the advisor) that make SLUB's debugfs > files alloc_traces and free_traces more useful. > The resubmission was blocked on stackdepot changes that are now merged, > as explained in patch 2. > Hello. I just started review/testing this series. it crashed on my system (arm64) I ran with boot parameter slub_debug=U, and without KASAN. So CONFIG_STACKDEPOT_ALWAYS_INIT=n. void * __init memblock_alloc_try_nid( phys_addr_t size, phys_addr_t align, phys_addr_t min_addr, phys_addr_t max_addr, int nid) { void *ptr; memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pS\n", __func__, (u64)size, (u64)align, nid, &min_addr, &max_addr, (void *)_RET_IP_); ptr = memblock_alloc_internal(size, align, min_addr, max_addr, nid, false); if (ptr) memset(ptr, 0, size); <--- Crash Here return ptr; } It crashed during create_boot_cache() -> stack_depot_init() -> memblock_alloc(). I think That's because, in kmem_cache_init(), both slab and memblock is not available. (AFAIU memblock is not available after mem_init() because of memblock_free_all(), right?) Thanks! /* * Set up kernel memory allocators */ static void __init mm_init(void) { /* * page_ext requires contiguous pages, * bigger than MAX_ORDER unless SPARSEMEM. */ page_ext_init_flatmem(); init_mem_debugging_and_hardening(); kfence_alloc_pool(); report_meminit(); stack_depot_early_init(); mem_init(); mem_init_print_info(); kmem_cache_init(); /* * page_owner must be initialized after buddy is ready, and also after * slab is ready so that stack_depot_init() works properly */) > Patch 1 is a new preparatory cleanup. > > Patch 2 originally submitted here [1], was merged to mainline but > reverted for stackdepot related issues as explained in the patch. > > Patches 3-5 originally submitted as RFC here [2]. In this submission I > have omitted the new file 'all_objects' (patch 3/3 in [2]) as it might > be considered too intrusive so I will postpone it for later. The docs > patch is adjusted accordingly. > > Also available in git, based on v5.17-rc1: > https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slub-stackdepot-v1 > > I'd like to ask for some review before I add this to the slab tree. > > [1] https://lore.kernel.org/all/20210414163434.4376-1-glittao@gmail.com/ > [2] https://lore.kernel.org/all/20210521121127.24653-1-glittao@gmail.com/ > > Oliver Glitta (4): > mm/slub: use stackdepot to save stack trace in objects > mm/slub: aggregate and print stack traces in debugfs files > mm/slub: sort debugfs output by frequency of stack traces > slab, documentation: add description of debugfs files for SLUB caches > > Vlastimil Babka (1): > mm/slub: move struct track init out of set_track() > > Documentation/vm/slub.rst | 61 +++++++++++++++ > init/Kconfig | 1 + > mm/slub.c | 152 +++++++++++++++++++++++++------------- > 3 files changed, 162 insertions(+), 52 deletions(-) > > -- > 2.35.1 > > -- Thank you, You are awesome! Hyeonggon :-)