From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4098C433F5 for ; Fri, 25 Feb 2022 08:13:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F1618D0002; Fri, 25 Feb 2022 03:13:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A0288D0001; Fri, 25 Feb 2022 03:13:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18FC68D0002; Fri, 25 Feb 2022 03:13:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 0AD9C8D0001 for ; Fri, 25 Feb 2022 03:13:50 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AF1BB1808A24D for ; Fri, 25 Feb 2022 08:13:49 +0000 (UTC) X-FDA: 79180588578.30.4BC3D3F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id E5D1C1C0005 for ; Fri, 25 Feb 2022 08:13:48 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 742391F383; Fri, 25 Feb 2022 08:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1645776827; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9XUtHgFIXz3Y7VU5CfuvkiImWSSj6M2SSPgIuQZxWw=; b=P51WeZJwQaSXAs3kehFkP5GgGwrp0kmlZJytxgvWQc9SXsNbzmcUW37g2LTuqRdG6+JVHX x49lzoHoYwtXjQ9ason8Vzr7s9hOBPm1En8NXOGujqR4T2RM+XUx4MdLOeKZL0Q7hYIfIQ AiUg+xtD4wBqtK75jF2ZvixJTvQ968A= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 472EEA3B81; Fri, 25 Feb 2022 08:13:47 +0000 (UTC) Date: Fri, 25 Feb 2022 09:13:46 +0100 From: Michal Hocko To: Wei Yang Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] mm/memcg: some cleanup for mem_cgroup_iter() Message-ID: References: <20220225003437.12620-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225003437.12620-1-richard.weiyang@gmail.com> X-Stat-Signature: p656xurf61q8jy1xedi7uxnf5bj5tbd9 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=P51WeZJw; spf=pass (imf20.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E5D1C1C0005 X-HE-Tag: 1645776828-321277 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 25-02-22 00:34:34, Wei Yang wrote: > No functional change, try to make it more readable. > > Wei Yang (3): > mm/memcg: set memcg after css verified and got reference > mm/memcg: set pos to prev unconditionally > mm/memcg: move generation assignment and comparison together > > mm/memcontrol.c | 27 ++++++++++++--------------- > 1 file changed, 12 insertions(+), 15 deletions(-) I am sorry but I do not really see these changes to be simplifying the iterator code enough to be worth touching the code. The iterator code is really subtle and we have experienced some subtle bugs there. I would be really reluctant to touch it unless the result is a clear simplification or a bug fix. Please keep in mind that the review overhead is far from negligible here. Unless Johannes sees that as a clear improvement then I would suggest dropping these patches from the akpm's tree. -- Michal Hocko SUSE Labs