From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2FD0C433EF for ; Thu, 24 Feb 2022 22:02:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23C2F8D0002; Thu, 24 Feb 2022 17:02:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EB388D0001; Thu, 24 Feb 2022 17:02:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9D28D0002; Thu, 24 Feb 2022 17:02:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id F2C2B8D0001 for ; Thu, 24 Feb 2022 17:02:29 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A7EC598782 for ; Thu, 24 Feb 2022 22:02:29 +0000 (UTC) X-FDA: 79179048018.27.ADB9B49 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 42CA110001F for ; Thu, 24 Feb 2022 22:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W/M4h+Wc7afgAQolO9V8hencFRzUNhasCzwSblw7Pxo=; b=IH0Zoluc/B7clTwJrdxD86Jlpl Thdkbi8MQrXEkA6LA0vTZEQflLec3i9qdGhyMVIIVKOCkOCjYQH6pmBc6n8R5BEpgY2HWOFddUQPU EVsNCvRp/xJ6n7OYRHtB9UGMSxZwhPFkOhLMXACgEfT0CrPmDyNKQ44RdfhwmfzVicXGxUA9siCEK O4l7RQOb3XIsSqQnSOALuoR+xvo9DkAZogTwxWABFiSnSGieFOQl0OCCOBqNY7nbhzrUBlE2MwkiF UgFsgoBOhw49wUd5Ac/VUR9r4S0ZJ9r2BnUC1WCj7OHlcQrVdp+VRkkbODh+CbiXCtlBfPoXPr4YA jfm9urZQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNMBu-005BBf-6W; Thu, 24 Feb 2022 22:02:26 +0000 Date: Thu, 24 Feb 2022 22:02:26 +0000 From: Matthew Wilcox To: Yang Li Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH -next] mm/rmap: Fix argument list that the kdoc format and script verified. Message-ID: References: <20220224014344.99537-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224014344.99537-1-yang.lee@linux.alibaba.com> Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IH0Zoluc; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 42CA110001F X-Stat-Signature: 7qdrkddtw83xxs4hop1wi8abagsbjjes X-HE-Tag: 1645740149-374660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 09:43:44AM +0800, Yang Li wrote: > The warnings were found by running scripts/kernel-doc, which is > caused by using 'make W=1'. > > mm/rmap.c:1684: warning: Function parameter or member 'folio' not > described in 'try_to_unmap' > mm/rmap.c:1684: warning: Excess function parameter 'page' description in > 'try_to_unmap' Fixed these like this instead: /** - * try_to_unmap - try to remove all page table mappings to a page - * @page: the page to get unmapped + * try_to_unmap - Try to remove all page table mappings to a folio. + * @folio: The folio to unmap. * @flags: action and flags * * Tries to remove all the page table entries which are mapping this - * page, used in the pageout path. Caller must hold the page lock. + * folio. It is the caller's responsibility to check if the folio is + * still mapped if needed (use TTU_SYNC to prevent accounting races). * - * It is the caller's responsibility to check if the page is still - * mapped when needed (use TTU_SYNC to prevent accounting races). + * Context: Caller must hold the folio lock. */