From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A82C433EF for ; Thu, 24 Feb 2022 19:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E08678D0002; Thu, 24 Feb 2022 14:36:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7E88D0001; Thu, 24 Feb 2022 14:36:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA6728D0002; Thu, 24 Feb 2022 14:36:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id B7AE18D0001 for ; Thu, 24 Feb 2022 14:36:49 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8BBE12393B for ; Thu, 24 Feb 2022 19:36:49 +0000 (UTC) X-FDA: 79178680938.02.A41E496 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 87D614000E for ; Thu, 24 Feb 2022 19:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DHjk/Pba+QVLWlWF2Zks/fYTFKkHfVyFF2WD9yUlSa0=; b=GwlaLygVF/HTZCVgNf2Lv1VPbW 92sv7NjDKx7rbn7hZD8wgTgR5ZnlrZ/6BjBypZsjEaUZAE7F7HoRz6ndg5NfS53pLOGa2Zcc2Vqxh IRVtsjeFP2wEW6qw2lzom4dz4ah0lc/bfISjp/roB6IxznaMb+aDv0x3fTfH31zL0OEk8DrWqZ/z0 I0Hq6Kr6/+ar47fyUlr3wncyxJQwtLX3APQVyuo6q171W8mPzMM0BSjeYpBwWXIH8UH4ISwTnQ46m 3FoYnBQVFLxjnPmwkFBV5AmnbV0t54bVea79+T6ngd+YLVguMe8QsxuY0Hhfv9L0hI2xxdT/0Cj/x xQmhrzyQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNJuc-0054m1-SN; Thu, 24 Feb 2022 19:36:27 +0000 Date: Thu, 24 Feb 2022 19:36:26 +0000 From: Matthew Wilcox To: Liam Howlett Cc: kernel test robot , "kbuild-all@lists.01.org" , Linux Memory Management List Subject: Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)' Message-ID: References: <202202241817.MXoE0NcM-lkp@intel.com> <20220224184246.llajk5tk7nyydwfv@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224184246.llajk5tk7nyydwfv@revolver> X-Rspamd-Queue-Id: 87D614000E X-Stat-Signature: osat9w3mb9wumozkr856thwd3frdrxko Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GwlaLygV; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1645731408-780080 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 24, 2022 at 06:42:52PM +0000, Liam Howlett wrote: > > include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)' > > 589 | static inline void mt_init(struct maple_tree *mt) > > | ^~~~~~~ > > > > > > vim +233 arch/mips/kernel/mips-mt.c > > > Naming is hard, all the good ones are taken. I'll rename the maple tree > init. Actually, I think it's probably better to rename the existing one. mips_mt_init() would be fine.