From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C70CBC433EF for ; Thu, 24 Feb 2022 08:36:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B9618D0002; Thu, 24 Feb 2022 03:36:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 268C88D0001; Thu, 24 Feb 2022 03:36:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 158D68D0002; Thu, 24 Feb 2022 03:36:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id EC4778D0001 for ; Thu, 24 Feb 2022 03:36:24 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A13462335E for ; Thu, 24 Feb 2022 08:36:24 +0000 (UTC) X-FDA: 79177016688.07.7EFAD4A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf06.hostedemail.com (Postfix) with ESMTP id C3D1B180009 for ; Thu, 24 Feb 2022 08:36:23 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A506E21115; Thu, 24 Feb 2022 08:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1645691782; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9kxeMpmspxDnMPyUwwwglML2VZu3aREU/aXhTjOO0II=; b=hXnAV7FJ9LTqyCSI73ZNNagLQq/kYhrpqsSqwH3Ldqm+docdyf0SgGSo2VgrHBUNRJLSz3 +9h7bzd8v1uzsuDevmz9FCgi3dBQ5OahEzFYrmReSJHIg9vRI5gxGV1leiCaJLC2QF+jS2 Jo/xO+XIFuwpWw+uWxZJ1GED3vh5ClM= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 65634A3B83; Thu, 24 Feb 2022 08:36:15 +0000 (UTC) Date: Thu, 24 Feb 2022 09:36:19 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, ccross@google.com, sumit.semwal@linaro.org, dave.hansen@intel.com, keescook@chromium.org, willy@infradead.org, kirill.shutemov@linux.intel.com, vbabka@suse.cz, hannes@cmpxchg.org, ebiederm@xmission.com, brauner@kernel.org, legion@kernel.org, ran.xiaokai@zte.com.cn, sashal@kernel.org, chris.hyser@oracle.com, dave@stgolabs.net, pcc@google.com, caoxiaofeng@yulong.com, david@redhat.com, gorcunov@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 1/3] mm: refactor vm_area_struct::anon_vma_name usage code Message-ID: References: <20220223153613.835563-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220223153613.835563-1-surenb@google.com> X-Rspamd-Queue-Id: C3D1B180009 X-Stat-Signature: er3o4o9mn7suftmwunikm58fqre3pkjt X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=hXnAV7FJ; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam05 X-HE-Tag: 1645691783-239634 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 23-02-22 07:36:11, Suren Baghdasaryan wrote: > Avoid mixing strings and their anon_vma_name referenced pointers > by using struct anon_vma_name whenever possible. This simplifies > the code and allows easier sharing of anon_vma_name structures when > they represent the same name. > > Suggested-by: Matthew Wilcox > Suggested-by: Michal Hocko > Signed-off-by: Suren Baghdasaryan LGTM Acked-by: Michal Hocko Thanks and one minor nit below [...] > +static inline void free_anon_vma_name(struct vm_area_struct *vma) > { > - const char *vma_name = vma_anon_name(vma); > + /* > + * Not using anon_vma_name because it generates a warning if vma->vm_mm > + * is not held, which might be the case here. s@vma->vm_mm@mmap_lock@ > + */ > + if (!vma->vm_file) > + anon_vma_name_put(vma->anon_name); > +} > > - /* either both NULL, or pointers to same string */ > - if (vma_name == name) -- Michal Hocko SUSE Labs