From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9570C433EF for ; Wed, 23 Feb 2022 16:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 568E88D0024; Wed, 23 Feb 2022 11:09:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 517A08D0011; Wed, 23 Feb 2022 11:09:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E1A88D0024; Wed, 23 Feb 2022 11:09:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 1B5618D0011 for ; Wed, 23 Feb 2022 11:09:48 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id B0D32120D81 for ; Wed, 23 Feb 2022 16:09:47 +0000 (UTC) X-FDA: 79174530414.06.FC871AF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id C9B62180008 for ; Wed, 23 Feb 2022 16:09:46 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 19C93CE1BC0; Wed, 23 Feb 2022 16:09:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AB5C340E7; Wed, 23 Feb 2022 16:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645632581; bh=dlIVpnDwmbEhoSgGlYaekfY+IuS9XO2thcEUMEMFHF8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tt5nRsFh/5YB64wdB2b4MLtrMwJA7jLjCx6Pnp0uDxpmJRmfRpxzupLMN+bNO9hzh HRAEw8R9bxwD5kRb2D/U8bJvPXrkgrh0Yfovq2W2QqoRCYz6GqK5eTiWn7uTgA+EI2 YxWiPU4JuANYIg9cwUGjdkvZ1uKtAPYfKmxViHW0= Date: Wed, 23 Feb 2022 17:09:38 +0100 From: Greg KH To: SeongJae Park Cc: akpm@linux-foundation.org, corbet@lwn.net, skhan@linuxfoundation.org, rientjes@google.com, xhao@linux.alibaba.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] mm/damon: Implement a minimal stub for sysfs-based DAMON interface Message-ID: References: <20220223152051.22936-1-sj@kernel.org> <20220223152051.22936-4-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220223152051.22936-4-sj@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C9B62180008 X-Stat-Signature: beacy7gi149gmdag61f4u1zcstufqp3u Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Tt5nRsFh; spf=pass (imf06.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1645632586-648750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 23, 2022 at 03:20:42PM +0000, SeongJae Park wrote: > +static struct kobj_attribute damon_sysfs_ul_range_min_attr = > + __ATTR(min, 0600, damon_sysfs_ul_range_min_show, > + damon_sysfs_ul_range_min_store); > + > +static struct kobj_attribute damon_sysfs_ul_range_max_attr = > + __ATTR(max, 0600, damon_sysfs_ul_range_max_show, > + damon_sysfs_ul_range_max_store); Can you use __ATTR_RW_MODE() instead here and elsewhere? thanks, greg k-h