From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB01C433F5 for ; Wed, 23 Feb 2022 03:27:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0D9C8D0002; Tue, 22 Feb 2022 22:27:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBD238D0001; Tue, 22 Feb 2022 22:27:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5CCD8D0002; Tue, 22 Feb 2022 22:27:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id A3F638D0001 for ; Tue, 22 Feb 2022 22:27:06 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 220EB181CAEE7 for ; Wed, 23 Feb 2022 03:27:05 +0000 (UTC) X-FDA: 79172608410.16.FF8561E Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf10.hostedemail.com (Postfix) with ESMTP id A7100C0002 for ; Wed, 23 Feb 2022 03:27:04 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id ev16-20020a17090aead000b001bc3835fea8so1537230pjb.0 for ; Tue, 22 Feb 2022 19:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hHo8dvg3ISjeopAogIYFlvrWZIJV/AddrIydDcQpt3s=; b=hHRgqWRLAGRwwt9P+lsaS5UqV2CgvlBTCAIjtKuJ4qUJatPXBGsKxO9Cp8jwcR9J3X 9g7TJzANL41E2EKpAg/L1t5M0O8zQ8n/1j7kbiYHK/s+w8mays/5dT3BGl40YRileQTa FkYyAZ70fNOxS3x5TZGytLWocSkCm4IP0DU3lUrwIUNaBJAe2HvcEJ4mp+NgNjJy8e1l lqzKqqkBk/1JFu8ru2lnmdaj+0Vaw3wK+K7ikmWJFgI7TiwkGy+iDHKZgnUwV3QirWvd 1IqhurJMpv3NlaocH2tMRStnKVjkpnhIKGhImduW+y5npvhKO4iMG+x2fME3qeP0y+OH h6tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hHo8dvg3ISjeopAogIYFlvrWZIJV/AddrIydDcQpt3s=; b=dyF920P+4+dWjUFbAypDyJN/i+1DDl2iIrD0sWfUF2tmtcVS+gwScq86FUahc0J7iX PwPJeDgTmk8NxId1JWwFqF6oT/WX0TcKgbld9Wbt8OOGmxwHeiEUA4DI6Pv/kSitv9IF Mgl2gRHJzbjW+5/qMeRkdn4oa3qMUr9iwPFpI7aHW2XfojXajhoVyGHzMsC1cWQujNPK 7vbexcyHNk4jkjr/n0/05ZlVpcQs1JUjtYl69JvCgFLj1g5AdUYDZf9Jw90SRlesoDU4 Gw+olRqu+HeFAEelxWUfDoXLsX0TZ31NNG9/n8enlR7KyUtDV9CClJR0hqWxydFrowuF 7inA== X-Gm-Message-State: AOAM5310VE1l5F7lkRsHVuirpseXcWl1KhwkMMzQ8J8uUfq7ios0HuNS XpCCGr4MFC61+abf1LUJxQs= X-Google-Smtp-Source: ABdhPJwxYlR5dh6SH2rWlwYCUwvH2cZs3/R4XfOmCMBhWE54GrIKCeyF4pSkRKkR/EqIX6lN8qG0Tw== X-Received: by 2002:a17:90a:b00d:b0:1bc:5d68:e7a8 with SMTP id x13-20020a17090ab00d00b001bc5d68e7a8mr7290589pjq.59.1645586823698; Tue, 22 Feb 2022 19:27:03 -0800 (PST) Received: from ip-172-31-19-208.ap-northeast-1.compute.internal (ec2-18-181-137-102.ap-northeast-1.compute.amazonaws.com. [18.181.137.102]) by smtp.gmail.com with ESMTPSA id na15sm1081334pjb.17.2022.02.22.19.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 19:27:03 -0800 (PST) Date: Wed, 23 Feb 2022 03:26:59 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Matthew Wilcox Cc: linux-mm@kvack.org, Roman Gushchin , Andrew Morton , Vlastimil Babka , linux-kernel@vger.kernel.org, Joonsoo Kim , David Rientjes , Christoph Lameter , Pekka Enberg Subject: Re: [PATCH 2/5] mm/sl[auo]b: Do not export __ksize() Message-ID: References: <20220221105336.522086-1-42.hyeyoo@gmail.com> <20220221105336.522086-3-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hHRgqWRL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A7100C0002 X-Stat-Signature: fgbx3jhs53h7ajzcty7cbmwcc4qdu69o X-HE-Tag: 1645586824-507687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 21, 2022 at 03:46:01PM +0000, Matthew Wilcox wrote: > On Mon, Feb 21, 2022 at 10:53:33AM +0000, Hyeonggon Yoo wrote: > > Do not export __ksize(). Only kasan calls __ksize() directly. > > We should probably delete (most of) the kernel-doc comment on __ksize, > leaving only the note that it's uninstrumented and only called by > kasan. Also, we should probably move the declaration of __ksize from > include/linux/slab.h to mm/slab.h since we don't want to grow new callers. Seems reasonable. I'll update it in next version! Thanks. -- Hyeonggon