From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F16BC433F5 for ; Wed, 23 Feb 2022 00:39:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 184578D0002; Tue, 22 Feb 2022 19:39:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 136758D0001; Tue, 22 Feb 2022 19:39:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0237B8D0002; Tue, 22 Feb 2022 19:39:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E34FB8D0001 for ; Tue, 22 Feb 2022 19:39:32 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AD3B52305A for ; Wed, 23 Feb 2022 00:39:32 +0000 (UTC) X-FDA: 79172186184.06.AD13BFF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id DB30940004 for ; Wed, 23 Feb 2022 00:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mnwTyMbUz81PkB25DhATLqknf9GX0qBtMJyqNEVfajI=; b=sxwmKsmhM6USGd256+56DlZH+0 xC8pp6lboBFRP88VnMkxrclwWkXe3f2XdwnKpvH+z8J4H/tQ5x09ss4WJqJVkAM/8uRMxpiUAzY8k AyeS04RXX0DgxaYuiz9AMQfFekUAfGn/iTMQFKj6mny1N2cySd/sYp/Ki4dS7xSO3WZksKlieMjvx DNPaYNbEj+CcHY464j7QkeJ9ifx4c671M2xsWMsvgHx7sB9b423IBlZMCQOxcQEwU0tGEZ0dGx3P3 2kjSKJ5KuCAEaG/rKPAQyKhlJjEtajugqivMXbR8raOSTL32LBDvaM+SIc4F07HFxDxmg8TLp4gEI aIA/+iPg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMfge-00C1fi-Tq; Wed, 23 Feb 2022 00:39:20 +0000 Date: Tue, 22 Feb 2022 16:39:20 -0800 From: Luis Chamberlain To: tangmeng Cc: Matthew Wilcox , viro@zeniv.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nizhen@uniontech.com, zhanglianjie@uniontech.com, nixiaoming@huawei.com, sujiaxun@uniontech.com Subject: Re: [PATCH 10/11] fs/drop_caches: move drop_caches sysctls to its own file Message-ID: References: <20220220060626.15885-1-tangmeng@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DB30940004 X-Stat-Signature: fpnf1hgjn1wd75xbytak1kt8kj9omiu8 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sxwmKsmh; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam05 X-HE-Tag: 1645576771-799343 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 21, 2022 at 09:55:18AM +0800, tangmeng wrote: > I think it is obviously the right thing that we need to do. Since you are following up on more changes, can you work on this? Brownie points if you show size results to refelct no size difference based on a new build with an example new user. > However, many submissions have been commited which registers an array > before, I think that having a register_sysctl_one() which registers exactly > one ctl_table should submit in a separate submission, rather than modify it > this time. We can optimize this later and fix those. Luis