From: Luis Chamberlain <mcgrof@kernel.org>
To: tangmeng <tangmeng@uniontech.com>
Cc: Matthew Wilcox <willy@infradead.org>,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
nizhen@uniontech.com, zhanglianjie@uniontech.com,
nixiaoming@huawei.com, sujiaxun@uniontech.com
Subject: Re: [PATCH 10/11] fs/drop_caches: move drop_caches sysctls to its own file
Date: Tue, 22 Feb 2022 16:39:20 -0800 [thread overview]
Message-ID: <YhWCOBqKc8xIylmT@bombadil.infradead.org> (raw)
In-Reply-To: <cbc60b32-d69c-d848-ca4c-650016da65d3@uniontech.com>
On Mon, Feb 21, 2022 at 09:55:18AM +0800, tangmeng wrote:
> I think it is obviously the right thing that we need to do.
Since you are following up on more changes, can you work on this?
Brownie points if you show size results to refelct no size difference
based on a new build with an example new user.
> However, many submissions have been commited which registers an array
> before, I think that having a register_sysctl_one() which registers exactly
> one ctl_table should submit in a separate submission, rather than modify it
> this time.
We can optimize this later and fix those.
Luis
next prev parent reply other threads:[~2022-02-23 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 6:06 tangmeng
2022-02-20 11:40 ` Matthew Wilcox
2022-02-21 1:55 ` tangmeng
2022-02-23 0:39 ` Luis Chamberlain [this message]
2022-02-23 9:51 ` tangmeng
2022-02-26 21:00 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhWCOBqKc8xIylmT@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nixiaoming@huawei.com \
--cc=nizhen@uniontech.com \
--cc=sujiaxun@uniontech.com \
--cc=tangmeng@uniontech.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
--cc=zhanglianjie@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox