From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF26C433F5 for ; Mon, 21 Feb 2022 15:47:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF51E8D0003; Mon, 21 Feb 2022 10:47:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA4638D0002; Mon, 21 Feb 2022 10:47:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D450B8D0003; Mon, 21 Feb 2022 10:47:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id C11418D0002 for ; Mon, 21 Feb 2022 10:47:43 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 61D58181F5FF2 for ; Mon, 21 Feb 2022 15:47:43 +0000 (UTC) X-FDA: 79167217206.31.72961D9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id D775014000A for ; Mon, 21 Feb 2022 15:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EV7HusSbqWhNkY6/yDWEBcroanF8730OLiwfi90dM0U=; b=PqmHvcn5WHBDlUEiZgM3d6y6X7 YSEkREN6468+QSX/Tp6pQPcMEU4y6x+2BZ+wooWcCbEGIA9VIfi8De17UjztlZPHS5jZWCe85tWr4 6Tp9Tj0ZhwCedYLwaS5ChBZN1M54jF/oKeLLc5tN2Ky7XucuTYPDsqUUm+k59QBOYPO6ar/iU7FWO Oh2dKPcmmBECbYYaxBLBhod3ZyVGXqBd94tp9MCmeZ67WmD8vLmIdwM/XbtwDGEE4B76cc9E2cc2Y 3rYaAj5ST6vRC1n8JkGKbRAlysqNKRKG+Ym/+pXyzucjhUo5GWzNBGGnSXVFKVa2w+vG56sA88q4q +g4H7anA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMAsz-001xOo-2s; Mon, 21 Feb 2022 15:46:01 +0000 Date: Mon, 21 Feb 2022 15:46:01 +0000 From: Matthew Wilcox To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: linux-mm@kvack.org, Roman Gushchin , Andrew Morton , Vlastimil Babka , linux-kernel@vger.kernel.org, Joonsoo Kim , David Rientjes , Christoph Lameter , Pekka Enberg Subject: Re: [PATCH 2/5] mm/sl[auo]b: Do not export __ksize() Message-ID: References: <20220221105336.522086-1-42.hyeyoo@gmail.com> <20220221105336.522086-3-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221105336.522086-3-42.hyeyoo@gmail.com> X-Rspamd-Queue-Id: D775014000A X-Stat-Signature: afiih83mzq1jwdopxjaegxwryxxxg3ka X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PqmHvcn5; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-HE-Tag: 1645458371-233613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 21, 2022 at 10:53:33AM +0000, Hyeonggon Yoo wrote: > Do not export __ksize(). Only kasan calls __ksize() directly. We should probably delete (most of) the kernel-doc comment on __ksize, leaving only the note that it's uninstrumented and only called by kasan. Also, we should probably move the declaration of __ksize from include/linux/slab.h to mm/slab.h since we don't want to grow new callers.