From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02004C433EF for ; Mon, 21 Feb 2022 09:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A00D8D0002; Mon, 21 Feb 2022 04:47:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84E948D0001; Mon, 21 Feb 2022 04:47:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73D8E8D0002; Mon, 21 Feb 2022 04:47:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 65A408D0001 for ; Mon, 21 Feb 2022 04:47:48 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2C6F0607FF for ; Mon, 21 Feb 2022 09:47:48 +0000 (UTC) X-FDA: 79166310216.04.468B7B4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf12.hostedemail.com (Postfix) with ESMTP id 8AAA340002 for ; Mon, 21 Feb 2022 09:47:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 722E82112A; Mon, 21 Feb 2022 09:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645436866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pk1xOipV5voJ7yLZv8MbUm0kEPSkqLDIOfh31PmClxA=; b=k8BT4upj2bStO1OCtFiwY1jBOjsjwsSnsET2IW0bw1Lu6nY7Tn/NWbtD88JN+WkYE4rAQU pjlMNjSsWtgkwwCPyPHHWVE8ChDhmyJQU2XXXMCr1qqYZDmruidPrGItZzcxyJoqbtCIzF eF7mGIDoocBo9Cmx6N3+lnJRn03qIBo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645436866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pk1xOipV5voJ7yLZv8MbUm0kEPSkqLDIOfh31PmClxA=; b=+Bowmqi+Vl0JzpdPI67vAqnY33YviVxSOCDS0L5dWiETe8ODC/QGFm5qpXEECRbHHzFBVR FSTucjG4TKupd+Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BBC3E13A7C; Mon, 21 Feb 2022 09:47:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id puNfKsFfE2IrDwAAMHmgww (envelope-from ); Mon, 21 Feb 2022 09:47:45 +0000 Date: Mon, 21 Feb 2022 10:47:44 +0100 From: Oscar Salvador To: Michal Hocko Cc: Andrew Morton , David Hildenbrand , Rafael Aquini , Dave Hansen , Wei Yang , Dennis Zhou , Alexey Makhalov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] arch/x86/mm/numa: Do not initialize nodes twice Message-ID: References: <20220218224302.5282-1-osalvador@suse.de> <20220218224302.5282-2-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8AAA340002 X-Stat-Signature: uiopjefmx8fjz4uo1ubj3uqp8x8mhbqh Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=k8BT4upj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+Bowmqi+; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1645436867-492696 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 21, 2022 at 10:20:02AM +0100, Michal Hocko wrote: > On Fri 18-02-22 23:43:02, Oscar Salvador wrote: > > Why setting the node online saves us then? Well, simply because > > __try_online_node() backs off when the node is online, meaning > > we do not end up calling register_one_node() in the first place. > > This is really a mess and a house built on sand. Thanks for looking into > it and hopefully this can get cleaned up to a saner state. Yes, I am willing to have a deep look into that and see how we can improve the situation. > This sha1 is from linux-next very likely so it won't be persistent. > Please drop it. Yes, it is. I guess it is fine to not have a "Fixes" tag here, so I will remove it then. > I would stick a TODO here. > /* > * Exclude this node from > * bringup_nonboot_cpus > * cpu_up > * __try_online_node > * register_one_node > * because node_subsys is not initialized yet > * TODO remove dependency on node_online() > */ Sure, will do. Thanks! -- Oscar Salvador SUSE Labs