From: Oscar Salvador <osalvador@suse.de>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Rafael Aquini <raquini@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Wei Yang <richard.weiyang@gmail.com>,
Dennis Zhou <dennis@kernel.org>,
Alexey Makhalov <amakhalov@vmware.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arch/x86/mm/numa: Do not initialize nodes twice
Date: Mon, 21 Feb 2022 10:47:44 +0100 [thread overview]
Message-ID: <YhNfwCO3xTIavi5v@localhost.localdomain> (raw)
In-Reply-To: <YhNZQgGSZglGQvcg@dhcp22.suse.cz>
On Mon, Feb 21, 2022 at 10:20:02AM +0100, Michal Hocko wrote:
> On Fri 18-02-22 23:43:02, Oscar Salvador wrote:
> > Why setting the node online saves us then? Well, simply because
> > __try_online_node() backs off when the node is online, meaning
> > we do not end up calling register_one_node() in the first place.
>
> This is really a mess and a house built on sand. Thanks for looking into
> it and hopefully this can get cleaned up to a saner state.
Yes, I am willing to have a deep look into that and see how we can
improve the situation.
> This sha1 is from linux-next very likely so it won't be persistent.
> Please drop it.
Yes, it is. I guess it is fine to not have a "Fixes" tag here, so I will
remove it then.
> I would stick a TODO here.
> /*
> * Exclude this node from
> * bringup_nonboot_cpus
> * cpu_up
> * __try_online_node
> * register_one_node
> * because node_subsys is not initialized yet
> * TODO remove dependency on node_online()
> */
Sure, will do.
Thanks!
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2022-02-21 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 22:43 [PATCH 0/1] Fix allocating nodes twice on x86 Oscar Salvador
2022-02-18 22:43 ` [PATCH 1/1] arch/x86/mm/numa: Do not initialize nodes twice Oscar Salvador
2022-02-21 9:20 ` Michal Hocko
2022-02-21 9:47 ` Oscar Salvador [this message]
2022-02-21 13:32 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhNfwCO3xTIavi5v@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=amakhalov@vmware.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=raquini@redhat.com \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox