From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CEE3C433F5 for ; Mon, 21 Feb 2022 08:42:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0FA8D0002; Mon, 21 Feb 2022 03:42:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 870768D0001; Mon, 21 Feb 2022 03:42:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75F5D8D0002; Mon, 21 Feb 2022 03:42:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 65E468D0001 for ; Mon, 21 Feb 2022 03:42:42 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 10920181CAEC5 for ; Mon, 21 Feb 2022 08:42:42 +0000 (UTC) X-FDA: 79166146164.17.1AC8846 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 7264FC0002 for ; Mon, 21 Feb 2022 08:42:41 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 07B18210F1; Mon, 21 Feb 2022 08:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1645432960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uKFt/N+8mBXiCo680jK/s9GGlKg4WZTYdNslDXFxjaY=; b=WerxlvgHjexW/2CKFS8CNWaeekIIAu9Uoo1rt4Ic1kUoC87Zx5nE3NQ/j9at9Vs/UUTj2f ifP4whASPJFx9wemCx4VczT0xSntWtAtX3pS1NL7F8HpJRAbRFUwDtHGIiYB3t5LXIYSvE vBQEWRunuFHRGGEYZqUNSE7h/tFyuYA= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C61D5A3B87; Mon, 21 Feb 2022 08:42:39 +0000 (UTC) Date: Mon, 21 Feb 2022 09:42:39 +0100 From: Michal Hocko To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zhenguo Yao , Liu Yuntao , Dan Carpenter , Andrew Morton Subject: Re: [PATCH v2] hugetlb: clean up potential spectre issue warnings Message-ID: References: <20220218212946.35441-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220218212946.35441-1-mike.kravetz@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7264FC0002 X-Stat-Signature: 81yc8oy36r3ga94tz5edkajm1rxkpbso Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WerxlvgH; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1645432961-625485 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 18-02-22 13:29:46, Mike Kravetz wrote: [...] > @@ -4161,7 +4162,7 @@ static int __init hugepages_setup(char *s) > } > if (tmp >= nr_online_nodes) > goto invalid; > - node = tmp; > + node = array_index_nospec(tmp, nr_online_nodes); > p += count + 1; > /* Parse hugepages */ > if (sscanf(p, "%lu%n", &tmp, &count) != 1) > @@ -6889,9 +6890,9 @@ static int __init cmdline_parse_hugetlb_cma(char *p) > break; > > if (s[count] == ':') { > - nid = tmp; > - if (nid < 0 || nid >= MAX_NUMNODES) > + if (tmp >= MAX_NUMNODES) > break; > + nid = array_index_nospec(tmp, MAX_NUMNODES); > > s += count + 1; > tmp = memparse(s, &s); This is an early boot code, how is this supposed to be used as a side channel? -- Michal Hocko SUSE Labs