From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D23C433EF for ; Sun, 20 Feb 2022 00:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9282D6B0071; Sat, 19 Feb 2022 19:40:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D7676B0073; Sat, 19 Feb 2022 19:40:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 778A36B0074; Sat, 19 Feb 2022 19:40:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 6BC3D6B0071 for ; Sat, 19 Feb 2022 19:40:19 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 13C4A9637E for ; Sun, 20 Feb 2022 00:40:19 +0000 (UTC) X-FDA: 79161301716.09.26A437E Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 88F8A120003 for ; Sun, 20 Feb 2022 00:40:18 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id l17so365866plg.0 for ; Sat, 19 Feb 2022 16:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tw8RZzbeX9t9efzXQPIpRkW11f9vjCrn+5xc7rNgm3I=; b=jcy+QNQ+y3GSI5OS6OAdyoGiwSBaSk8A0F/5b4kP86a31nh3X9W0ynEVYnMLFq32jN jeXsxHLMnPmdZyc6eiudjOq/4s+5BVK7qRgw5secQmayB02ERmKLPkJCTDcRaK7SjYP1 gaqlTgzliin8LjfyccQVYLv/03CMTpE8Uh3Vgwoc7mxWFBHxoX3TB+dB4ZJPMsnOKohd tJcr4XpXd3m1JdeTkMLpNLQnbg0PFeQz+tOTM6hRkRuW1JQYzvs0uP2Yc7HVNs9Qt5tb HPeq61244eZB384qEv5GDPNHDhdE9R05c6+qb05hX9rH/lFRVwgA//Xs+p31trMYCGPV p3GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=tw8RZzbeX9t9efzXQPIpRkW11f9vjCrn+5xc7rNgm3I=; b=hsHN8Vhv9O1wzaY9G+BbT6j7/0WXwYwdQFEegHcttCcdvxgInVTP8Qh5Jojrg+ViUf rmwFkFXxrxtDubFtX1bOF/nQUqlkAeVeZKCpZyaI0Ol+0nq2Nqcoo8lIbbQNAMhN7ywG PNbEGr0J0bf6MqIcWR3m7/SpBfolN6nPSeSzS5TtZ2hrLh0iNrs5wcfnHw0OvtRGY1Yg 1a515fCOAyaF2OgMN1YnahqdZoCmdKUYkCiXWG/8Skm1p53/swHuFTFt9POfs7z87kM4 LbP+UogW533g+5IhOPXZZRfj6Ogn+Zlkv4hLGFBiCs4+2h7IxAtgQ6hPIvv+2g99WxGL VIGA== X-Gm-Message-State: AOAM530N1BydUzXdM8jYHhtHpvkXIoqj5igTTFSH3OfdEZz+02huip1e FunWEXK4i+041FEn6/hVlxg= X-Google-Smtp-Source: ABdhPJwakSOU376iWNt62bLbZa4QyGu3LCtLZAGqtP7NNP7JpLC55aLyTAEFmhqSQArxLqD1BvU5bg== X-Received: by 2002:a17:902:ea0a:b0:14f:206c:e3df with SMTP id s10-20020a170902ea0a00b0014f206ce3dfmr13265550plg.145.1645317617494; Sat, 19 Feb 2022 16:40:17 -0800 (PST) Received: from google.com ([2620:15c:211:201:a108:7030:d9de:a46b]) by smtp.gmail.com with ESMTPSA id e15sm7654954pfv.104.2022.02.19.16.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Feb 2022 16:40:16 -0800 (PST) Date: Sat, 19 Feb 2022 16:40:14 -0800 From: Minchan Kim To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, peterz@infradead.org, guro@fb.com, shakeelb@google.com, timmurray@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 1/1] mm: count time in drain_all_pages during direct reclaim as memory pressure Message-ID: References: <20220219174940.2570901-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219174940.2570901-1-surenb@google.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 88F8A120003 X-Stat-Signature: jdmf9dz7ectezzd3kuwfofgbixfqm4nj Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jcy+QNQ+; spf=pass (imf29.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspam-User: X-HE-Tag: 1645317618-895207 X-Bogosity: Ham, tests=bogofilter, spamicity=0.010905, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 09:49:40AM -0800, Suren Baghdasaryan wrote: > When page allocation in direct reclaim path fails, the system will > make one attempt to shrink per-cpu page lists and free pages from > high alloc reserves. Draining per-cpu pages into buddy allocator can > be a very slow operation because it's done using workqueues and the > task in direct reclaim waits for all of them to finish before Yes, drain_all_pages is serious slow(100ms - 150ms on Android) especially when CPUs are fully packed. It was also spotted in CMA allocation even when there was on no memory pressure. > proceeding. Currently this time is not accounted as psi memory stall. Good spot. > > While testing mobile devices under extreme memory pressure, when > allocations are failing during direct reclaim, we notices that psi > events which would be expected in such conditions were not triggered. > After profiling these cases it was determined that the reason for > missing psi events was that a big chunk of time spent in direct > reclaim is not accounted as memory stall, therefore psi would not > reach the levels at which an event is generated. Further investigation > revealed that the bulk of that unaccounted time was spent inside > drain_all_pages call. > > Annotate drain_all_pages and unreserve_highatomic_pageblock during > page allocation failure in the direct reclaim path so that delays > caused by these calls are accounted as memory stall. > > Reported-by: Tim Murray > Signed-off-by: Suren Baghdasaryan > --- > mm/page_alloc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3589febc6d31..7fd0d392b39b 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4639,8 +4639,12 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, > * Shrink them and try again > */ > if (!page && !drained) { > + unsigned long pflags; > + > + psi_memstall_enter(&pflags); > unreserve_highatomic_pageblock(ac, false); > drain_all_pages(NULL); > + psi_memstall_leave(&pflags); Instead of annotating the specific drain_all_pages, how about moving the annotation from __perform_reclaim to __alloc_pages_direct_reclaim?