From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F90C433EF for ; Tue, 1 Mar 2022 09:55:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A28F8D0002; Tue, 1 Mar 2022 04:55:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6521F8D0001; Tue, 1 Mar 2022 04:55:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 540CF8D0002; Tue, 1 Mar 2022 04:55:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 42BB88D0001 for ; Tue, 1 Mar 2022 04:55:25 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EB88A8249980 for ; Tue, 1 Mar 2022 09:55:24 +0000 (UTC) X-FDA: 79195359768.22.F6565B7 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id 544581C0006 for ; Tue, 1 Mar 2022 09:55:24 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3B84B81856; Tue, 1 Mar 2022 09:55:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B5F9C340EE; Tue, 1 Mar 2022 09:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646128521; bh=8YjTRp7NuUv65z90+NN5SmTpZZtNhw5jeBiXRggxlOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DQgKSnJwn0l0I3BAOltTsJBNcSxl6GThPSHqvZTrMtG6vLn7K0TWQp55sepHrgWYM FaWeEUl39+Q3V6gV4f816/foCdaz52QegnFGvDy3OwX5vbWefq9SDBieVs3iR/tS3w TdObEGBaWClFRA2pjr2oF4Kr56dDV/dyCXJg8KlOlFoBnEO1elGSkVEEiYzNac6+j0 JBGu5BTq0xUAgqidKRXGvyW0VOvAonuD2IxhL4FBHvdGNLRIpwdu0pOEDVPvF+UBO3 rw2sSBUHw1EYUvjbpxTG+bp2zvp3ZBjVesUryTsfizAZ7RgPnOq+7/jdbMy1ztLck6 AY3caNkCuWQJA== Date: Tue, 1 Mar 2022 11:55:14 +0200 From: Mike Rapoport To: Tiezhu Yang Cc: Thomas Bogendoerfer , Andrew Morton , Xuefeng Li , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/4] MIPS: Modify mem= and memmap= parameter Message-ID: References: <1646108941-27919-1-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1646108941-27919-1-git-send-email-yangtiezhu@loongson.cn> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 544581C0006 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DQgKSnJw; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: qxhwf8nfp4b65b3euuxyef8xr8fcqx66 X-HE-Tag: 1646128524-422567 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Tue, Mar 01, 2022 at 12:28:57PM +0800, Tiezhu Yang wrote: > In the current code, the kernel command-line parameter mem= and memmap= > can not work well on MIPS, this patchset refactors the related code to > fix them. > > For kdump on MIPS, if the users want to limit the memory region for the > capture kernel to avoid corrupting the memory image of the panic kernel, > use the parameter memmap=limit@base is the proper way, I will submit a > patch to use memmap=limit@base for kexec-tools after this patchset is > applied. Sorry, apparently I misread the prevoius version. What's wrong with the current implementation of mem=limit@base for the kdump case? > v4: Fix some build warnings reported by kernel test robot > > v3: Modify patch #3 to maintain compatibility for memmap=limit{$,#,!}base, > commented by Mike Rapoport, thank you > > v2: Add some new patches to support memmap=limit@base > > Tiezhu Yang (4): > MIPS: Refactor early_parse_mem() to fix mem= parameter > memblock: Introduce memblock_mem_range_remove_map() > MIPS: Refactor early_parse_memmap() to fix memmap= parameter > MIPS: Remove not used variable usermem > > arch/mips/kernel/setup.c | 69 ++++++++++++++++++++++-------------------------- > include/linux/memblock.h | 1 + > mm/memblock.c | 9 +++++-- > 3 files changed, 40 insertions(+), 39 deletions(-) > > -- > 2.1.0 > -- Sincerely yours, Mike.