From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DAC6C433EF for ; Wed, 2 Mar 2022 15:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A25AE8D0003; Wed, 2 Mar 2022 10:47:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ACF18D0001; Wed, 2 Mar 2022 10:47:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84E628D0003; Wed, 2 Mar 2022 10:47:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 71C3D8D0001 for ; Wed, 2 Mar 2022 10:47:20 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 303D28249980 for ; Wed, 2 Mar 2022 15:47:20 +0000 (UTC) X-FDA: 79199875440.17.99B0DF6 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf24.hostedemail.com (Postfix) with ESMTP id AA9A8180014 for ; Wed, 2 Mar 2022 15:47:19 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id w37so1955779pga.7 for ; Wed, 02 Mar 2022 07:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+TXEHf/Ffw9IRANu1j/U09cF+iyN1ryNSiaGmtROC/c=; b=E9TP1aQWp7/Dq8MS1gRXWqpotSaejMD0Vl/XuhfYiXbfMlpPINIjlSdESYNCIXZsUH iKLdYY+9gbkouxRibpbnlb/+rF4+t+FUMd4+3SR57L5gyqaWzlC6BfnDV0Krffq13wzI q3UChBYZk4RTPQao8TEy6OdZWUFWwUck+ou32qXsoJ/6bDf4XADKkTSCEvM+xSUhLYup sbApjAGmkm6UfcSLTDMfqsVToQ/zJMi1j5mAxsYFdRuMP+7Y2Li8GRp4qvsMRMIgDOOz 3zC9BacGl7B5rjFLqmhtRsFcN/cU92MBf4/awNcFN0hWrYoUJX/+isEqApPRtxLDOuIu QiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=+TXEHf/Ffw9IRANu1j/U09cF+iyN1ryNSiaGmtROC/c=; b=FXMPiMaRIgRKpyvfMYUj9EeobzHYgejPIglFtzSz6jqmyiZ0KMNQC8PLveLuIsNHGR ab8Ur3HOWd8E/ZX7CU0zs0IXAz56Q2aeVwCBjDranaCr5C3yH009SNKwJ9SheMJPXN96 6LShCLusHmzB+PSNXEj7yt3AH6oeBKX12guAbLuEKKs/BwkXoJOG0wy7P1j/sq1/4xKf 76fzIhuvSNey7DEJVYzPWzTRfzU9rkxs0wZ/gGAT1BA+9pJgioCWgkPiHF6qIR6wis/S lN6/wOwoP91HZj2N8p8ay5AW6Lpz2hgoND2nyKWBkIuPOc+zAhe+OGvbMCRrvs/V+7pY sQSg== X-Gm-Message-State: AOAM532TBI0s0fqrAJcQyDH2xU2v3s5yXI6/wDLAijTOh6eiPKy1runf NhKspfY/FHwUlz7SqkXwwc4= X-Google-Smtp-Source: ABdhPJyoYh07lMjBuBomRI5JgoaB7rWOYjQlf/YyT320uasBvrJ3TCq8aca9m3/kK+sfGAMpgSSMsw== X-Received: by 2002:a63:9311:0:b0:372:710e:2263 with SMTP id b17-20020a639311000000b00372710e2263mr25909143pge.223.1646236038411; Wed, 02 Mar 2022 07:47:18 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id d5-20020a17090acd0500b001b9c05b075dsm5530501pju.44.2022.03.02.07.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 07:47:17 -0800 (PST) Date: Wed, 2 Mar 2022 05:47:16 -1000 From: Tejun Heo To: Sebastian Andrzej Siewior Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Zefan Li , Thomas Gleixner Subject: Re: [PATCH] cgroup: Add a comment to cgroup_rstat_flush_locked(). Message-ID: References: <[PATCH0/2]CorrectlockingassumptiononPREEMPT_RT> <20220301122143.1521823-1-bigeasy@linutronix.de> <20220301122143.1521823-2-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: AA9A8180014 X-Stat-Signature: m557j3tiggfaw11qrdhcuy4de8fxobgc X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=E9TP1aQW; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf24.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=htejun@gmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646236039-650417 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 02, 2022 at 03:46:16PM +0100, Sebastian Andrzej Siewior wrote: > Add a comment why spin_lock_irq() -> raw_spin_lock_irqsave() is needed. > > Signed-off-by: Sebastian Andrzej Siewior > --- > On 2022-03-01 20:38:51 [-1000], Tejun Heo wrote: > > Hello, > > Hello Tejun, > > > Can you please add a comment explaining why irqsave is being used? As it > > stands, it just looks spurious. > > Something like this? Yeah, looks good to me. Acked-by: Tejun Heo Thanks. -- tejun