From: Luis Chamberlain <mcgrof@kernel.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: corbet@lwn.net, mike.kravetz@oracle.com,
akpm@linux-foundation.org, keescook@chromium.org,
yzaikin@google.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
duanxiongchun@bytedance.com, smuchun@gmail.com,
Adam Manzanares <a.manzanares@samsung.com>,
Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: [PATCH v2 1/3] mm: hugetlb: disable freeing vmemmap pages when struct page crosses page boundaries
Date: Wed, 2 Mar 2022 13:21:49 -0800 [thread overview]
Message-ID: <Yh/f7YpP0Oc2Nkun@bombadil.infradead.org> (raw)
In-Reply-To: <20220302083758.32528-2-songmuchun@bytedance.com>
On Wed, Mar 02, 2022 at 04:37:56PM +0800, Muchun Song wrote:
> If CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON is enabled and the size
> of "struct page" is not power of two, we cannot optimize vmemmap pages
> of HugeTLB pages. We should disable this feature in this case.
The commit log does not descrie what happens if this is left enabled in
that case? Is this a fix? Why would it be a fix? Was something failing?
How did you spot this issue? What are the consequences of not applying
this patch?
Luis
next prev parent reply other threads:[~2022-03-02 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 8:37 [PATCH v2 0/3] add hugetlb_free_vmemmap sysctl Muchun Song
2022-03-02 8:37 ` [PATCH v2 1/3] mm: hugetlb: disable freeing vmemmap pages when struct page crosses page boundaries Muchun Song
2022-03-02 21:21 ` Luis Chamberlain [this message]
2022-03-03 2:38 ` Muchun Song
2022-03-03 0:25 ` Mike Kravetz
2022-03-03 2:28 ` Muchun Song
2022-03-02 8:37 ` [PATCH v2 2/3] sysctl: allow to set extra1 to SYSCTL_ONE Muchun Song
2022-03-02 8:37 ` [PATCH v2 3/3] mm: hugetlb: add hugetlb_free_vmemmap sysctl Muchun Song
2022-03-02 21:25 ` Luis Chamberlain
2022-03-03 11:15 ` Muchun Song
2022-03-03 14:59 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh/f7YpP0Oc2Nkun@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dave@stgolabs.net \
--cc=duanxiongchun@bytedance.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=smuchun@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox