From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA21C433EF for ; Tue, 15 Feb 2022 19:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCE4F6B0078; Tue, 15 Feb 2022 14:48:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7E4E6B007B; Tue, 15 Feb 2022 14:48:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B47266B007D; Tue, 15 Feb 2022 14:48:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id A28476B0078 for ; Tue, 15 Feb 2022 14:48:02 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 61F6F181200CF for ; Tue, 15 Feb 2022 19:48:02 +0000 (UTC) X-FDA: 79146050004.23.B901472 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf19.hostedemail.com (Postfix) with ESMTP id D123E1A0004 for ; Tue, 15 Feb 2022 19:48:01 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 76694212BB; Tue, 15 Feb 2022 19:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1644954480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+8sKBCqSR7c8DeTAhKuGbijewmKCWZ2dzd8jjJSZzJc=; b=rGjtYJKiX+naTjMsh0ukOUZ9niWyyUyCAvaxzv/9y5Mp6oz1oP4xoBKbvaiw3XSQJL/irz /o2OzMCCPdazBAA+8KxH3fX37mB3P5TYo0Og9Mv73Uj6U6Vsd1oTmDs05cDt+k9q+HS5UH 4NFkLtyJq86MAKYr0pnT6eZt0Q8+iqw= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id E4217A3B85; Tue, 15 Feb 2022 19:47:57 +0000 (UTC) Date: Tue, 15 Feb 2022 20:47:55 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, ccross@google.com, sumit.semwal@linaro.org, dave.hansen@intel.com, keescook@chromium.org, willy@infradead.org, kirill.shutemov@linux.intel.com, vbabka@suse.cz, hannes@cmpxchg.org, ebiederm@xmission.com, brauner@kernel.org, legion@kernel.org, ran.xiaokai@zte.com.cn, sashal@kernel.org, chris.hyser@oracle.com, dave@stgolabs.net, pcc@google.com, caoxiaofeng@yulong.com, david@redhat.com, gorcunov@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, syzbot+aa7b3d4b35f9dc46a366@syzkaller.appspotmail.com Subject: Re: [PATCH v3 1/1] mm: fix use-after-free when anon vma name is used after vma is freed Message-ID: References: <20220211013032.623763-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=rGjtYJKi; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam07 X-Rspam-User: X-Rspamd-Queue-Id: D123E1A0004 X-Stat-Signature: ui5jhfncfjsgm4ancqnkiwboenwcgt9a X-HE-Tag: 1644954481-948832 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Forgot to include one hunk: diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index cff619f762d0..17c20597e244 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -175,6 +175,11 @@ static inline void free_vma_anon_name(struct vm_area_struct *vma) anon_vma_name_put(vma->anon_name); } +static inline void dup_vma_anon_name(struct vm_area_struct *vma) +{ + anon_vma_name_get(vma->anon_name); +} + #else /* CONFIG_ANON_VMA_NAME */ static inline const char *vma_anon_name(struct vm_area_struct *vma) { @@ -187,6 +192,9 @@ static inline bool anon_vma_name_eq(struct anon_vma_name *name1, struct anon_vma static inline void free_vma_anon_name(struct vm_area_struct *vma) { } +static inline void dup_vma_anon_name(struct vm_area_struct *vma) +{ +} #endif /* CONFIG_ANON_VMA_NAME */ static inline void init_tlb_flush_pending(struct mm_struct *mm) diff --git a/kernel/fork.c b/kernel/fork.c index d75a528f7b21..dee514488003 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -366,7 +366,7 @@ struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) *new = data_race(*orig); INIT_LIST_HEAD(&new->anon_vma_chain); new->vm_next = new->vm_prev = NULL; - dup_vma_anon_name(orig, new); + dup_vma_anon_name(new); } return new; } -- Michal Hocko SUSE Labs