From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DFADC433FE for ; Tue, 15 Feb 2022 07:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A21476B007D; Tue, 15 Feb 2022 02:25:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A8EA6B007B; Tue, 15 Feb 2022 02:25:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 870646B007D; Tue, 15 Feb 2022 02:25:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 7900F6B0078 for ; Tue, 15 Feb 2022 02:25:49 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 30E11180AD837 for ; Tue, 15 Feb 2022 07:25:49 +0000 (UTC) X-FDA: 79144179618.06.1800DD2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id C3589100002 for ; Tue, 15 Feb 2022 07:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y1ta4A2pA3xRjz4+7DYg0bKTf6OOfSccy05vggXhPLk=; b=bnqG51VFpHj0J8j/HkvQIXOS3u vYp2owcYTeqkqGR8UV4NSxe6y5vOAsCwjo3XJPQbZrfGMNrF7BmDz0GdHxpnOSeryufQihNhbt+/Z W8j3p4aSzJm71sajEBG+/jJR+L3/eUROyrs+YtG9x7jO1+YEGHxW+vTsXrn414dS9bEfBTH7mtQLN k+hKgSMBMNu25dPdqKjStMfyJT3DRHn5ANfaHtXeRPra60J5iOcfQRWAm4DNW6/l8kKG1j9VyffKw UtVEe00aLeMU8dKB83qjVH7YO7GR6VROi5LjC0uLX8rwULZygk9G3TlFskS2TaRULuBWQvoOxjiTy p4jo3qVA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJsDb-001AoF-2b; Tue, 15 Feb 2022 07:25:47 +0000 Date: Mon, 14 Feb 2022 23:25:47 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio() Message-ID: References: <20220214200017.3150590-1-willy@infradead.org> <20220214200017.3150590-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220214200017.3150590-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: C3589100002 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=bnqG51VF; spf=none (imf05.hostedemail.com: domain of BATV+0ca47b70804f6e632d40+6750+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0ca47b70804f6e632d40+6750+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: judtqcd3ca68tswh1f4uu14pg4w96dn8 X-Rspamd-Server: rspam03 X-HE-Tag: 1644909948-965817 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 14, 2022 at 08:00:15PM +0000, Matthew Wilcox (Oracle) wrote: > This function has one caller which already has a reference to the > page, so we don't need to use get_page_unless_zero(). Also move the > prototype to mm/internal.h. Looks good: Reviewed-by: Christoph Hellwig