From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDBBC433FE for ; Tue, 15 Feb 2022 07:18:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 917946B0078; Tue, 15 Feb 2022 02:18:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A04F6B007B; Tue, 15 Feb 2022 02:18:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 767DF6B007D; Tue, 15 Feb 2022 02:18:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 636A46B0078 for ; Tue, 15 Feb 2022 02:18:00 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 189A7901AB for ; Tue, 15 Feb 2022 07:18:00 +0000 (UTC) X-FDA: 79144159920.23.AA995E8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 9D7F5C0005 for ; Tue, 15 Feb 2022 07:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Lh/4vU9mdF8EI5uwzlU0rCLsZXjqtBxSaTihRBxn1pU=; b=VkRqdL5cio50YFn/NoU25FxW8L W3N2Cwlzj3DvlCOFlJi1NaqjCHxvYE63rQAUapjBO4RBsQpSl1vecKtJ9sam3gnnLPM865g2GuCaP 9kqU/1OUItCjFhTIcF0SvekDI6zmRdnZTLkiwOtu2Wd/jvAgqoQBzECW4BMJVRrpPSaSbRROGvhp+ wgWj6nb1hYJ59CqHze5eA24Yuqv+80RvMUEccEs2gH7HPj5wsC4IP0kCtd5mUZvJyYnkI7W8jlLze 3VI6acaYCBvC+p7wGTraRbMBWk1zCuvlKZzSv3k/KqRl/lc4VasyFisxnrNHAwipRN0hn45jBhtqB iT9+3xSw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJs61-0016b5-Mj; Tue, 15 Feb 2022 07:17:57 +0000 Date: Mon, 14 Feb 2022 23:17:57 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 02/10] mm/truncate: Inline invalidate_complete_page() into its one caller Message-ID: References: <20220214200017.3150590-1-willy@infradead.org> <20220214200017.3150590-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220214200017.3150590-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9D7F5C0005 X-Stat-Signature: s39wzcmy1xwgho83yc6eg9a315ijm8jb Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VkRqdL5c; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+0ca47b70804f6e632d40+6750+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0ca47b70804f6e632d40+6750+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1644909479-767066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 14, 2022 at 08:00:09PM +0000, Matthew Wilcox (Oracle) wrote: > invalidate_inode_page() is the only caller of invalidate_complete_page() > and inlining it reveals that the first check is unnecessary (because we > hold the page locked, and we just retrieved the mapping from the page). > Actually, it does make a difference, in that tail pages no longer fail > at this check, so it's now possible to remove a tail page from a mapping. There is a comment that referneces invalidate_complete_page in kernel/futex/core.c which needs updating. Otherwise looks good: Reviewed-by: Christoph Hellwig