From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FC4C433EF for ; Fri, 11 Feb 2022 20:21:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5CCE6B0078; Fri, 11 Feb 2022 15:21:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0EE06B007B; Fri, 11 Feb 2022 15:21:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3E96B007D; Fri, 11 Feb 2022 15:21:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 7E9F06B0078 for ; Fri, 11 Feb 2022 15:21:00 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3D6B3180A62A3 for ; Fri, 11 Feb 2022 20:21:00 +0000 (UTC) X-FDA: 79131617880.26.F9CBDE3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 4E884C0004 for ; Fri, 11 Feb 2022 20:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iw00k9jskvLMRelaK3vjuX4Ipw5ug91ZREDXkAHjsJM=; b=rP3f+QsPkPnztfOWsgAd/0RoSN Ki0gZ/I+JRYzwFbetWo6Vl9zPQjmckZ6ZYSm8MHuI1TCCrmSacqIs0mW35K4L5Ct6lhgzDzleN38O v3E9gm6YGz54q/gsc0PugERLfdxA07uEcYqA9KRx3LWhvUu7aA7yHFxNySsZ6pUJgKnzE+9yIR3vM tpeiUReXOq/RPrllcZkLVG2gE6g4DGi1oiZPAa3pnF9BUlVC2skbe5AobhFflYb75OUMlDJsB7Zzu fm8o7+ZAmxK8jyVuTuz9iZM0IJS8mUHTJ82rUQIZWAWIIuQPB5uPc5O+7zN4p2h9G/RcRHCwvtj4f qKaZi3Kw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIcPU-00AhuL-R4; Fri, 11 Feb 2022 20:20:52 +0000 Date: Fri, 11 Feb 2022 20:20:52 +0000 From: Matthew Wilcox To: Mark Hemment Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , John Hubbard , Jason Gunthorpe , William Kucharski Subject: Re: [PATCH 20/75] mm/gup: Convert gup_pte_range() to use a folio Message-ID: References: <20220204195852.1751729-1-willy@infradead.org> <20220204195852.1751729-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rP3f+QsP; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam07 X-Rspam-User: X-Rspamd-Queue-Id: 4E884C0004 X-Stat-Signature: ihpkdj5appnhk49kjjmja7wq79ftzqmw X-HE-Tag: 1644610859-480877 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 06, 2022 at 02:52:46PM +0000, Mark Hemment wrote: > On Fri, 4 Feb 2022 at 20:21, Matthew Wilcox (Oracle) > wrote: > V. Minor/nit: Above the "goto pte_unmap;" is the code block; > if (flags & FOLL_PIN) { > ret = arch_make_page_accessible(page); > if (ret) { > unpin_user_page(page); > goto pte_unmap; > } > } > Other conditions which goto pte_unmap, after successful > try_grab_folio(), call gup_put_folio() (rather than > unpin_user_page()). > No change in functionality, but suggest calling gup_put_folio() here > too for consistency. Thanks! Changed.