From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4375EC433FE for ; Tue, 8 Feb 2022 10:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7D056B0071; Tue, 8 Feb 2022 05:15:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C09526B0075; Tue, 8 Feb 2022 05:15:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACD186B0078; Tue, 8 Feb 2022 05:15:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 991D56B0071 for ; Tue, 8 Feb 2022 05:15:08 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5CCC421325 for ; Tue, 8 Feb 2022 10:15:08 +0000 (UTC) X-FDA: 79119204696.01.B7C1258 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id DCDC020004 for ; Tue, 8 Feb 2022 10:15:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C186F1F383; Tue, 8 Feb 2022 10:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644315306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bmBoCspThb0e3/6sT933uzB0WbHZ0YSRYCjWmTB8oEw=; b=xwK4FNK4oRgULGk+hEaIWl2DMi2wGLEGEdRjGGURmkv8te32jqOeOWas55XHJ7GAnkdosR k/VH5rlFrqrZVJe2hJ+Q7S5ORY2sj+nTaoBdMs003KaXJqB3nX25IOcb7F/h6JHNGNuibn jzVV+JyHg459j+fzgitn7McurWs5N1A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644315306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bmBoCspThb0e3/6sT933uzB0WbHZ0YSRYCjWmTB8oEw=; b=Ox3NpwQAyyjdALliT+ueZqIpO+SUsJHjvMMhM5ihNNl7k8zulyFpvPEwjNcDs7J9SYcxfd HZRjbledr9cbOpCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6553713C08; Tue, 8 Feb 2022 10:15:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Dz3fFKpCAmLGcwAAMHmgww (envelope-from ); Tue, 08 Feb 2022 10:15:06 +0000 Date: Tue, 8 Feb 2022 11:15:04 +0100 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add_pages Message-ID: References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207133643.23427-2-linmiaohe@huawei.com> Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xwK4FNK4; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Ox3NpwQA; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: 8y3tej5e7w5cc5yx79yhx6afdckmpomi X-Rspamd-Queue-Id: DCDC020004 X-HE-Tag: 1644315307-868982 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 07, 2022 at 09:36:40PM +0800, Miaohe Lin wrote: > Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online"), there is no need to pass in the zone. > > Signed-off-by: Miaohe Lin Yeah, I am with David here, "Reasonably generic function for adding memory" does not really tell me much about that function. -- Oscar Salvador SUSE Labs