From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B79C433EF for ; Tue, 8 Feb 2022 10:12:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C486B0071; Tue, 8 Feb 2022 05:12:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CADC6B0075; Tue, 8 Feb 2022 05:12:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BBDD6B0078; Tue, 8 Feb 2022 05:12:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 1F6056B0071 for ; Tue, 8 Feb 2022 05:12:19 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DEE71951A8 for ; Tue, 8 Feb 2022 10:12:18 +0000 (UTC) X-FDA: 79119197556.31.C7B73D7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 65BC0140006 for ; Tue, 8 Feb 2022 10:12:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3A7A51F37C; Tue, 8 Feb 2022 10:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644315137; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iqwBMSaQFzyUIyxqXWmPp13Hp0jtduJNpkZuJ0rwnFQ=; b=L8UEVSKrQ+rwY8lgCeT7VNpSH9dnsBm2lWoqMAicLVEGJRxsw1nRjHrmqWEI79ExAcI1zf QL6FhrdpkLc3LXFECxdSTUNRD/oiaUQrOpJ5PtAqGqfCzgK0sYAxfwBJII5cJ6RFBo8wIl IHSGKLkF1/yHlgTSxE02U5fPUaV5RWQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644315137; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iqwBMSaQFzyUIyxqXWmPp13Hp0jtduJNpkZuJ0rwnFQ=; b=rIsf6VLKCCJrrC+ErRWJ7PjbiCvTnYtgraF2EvIV0dQNmx66ENmqDFm/32/dw8BdqGqJeK H/ydq8F704YnjbBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B916313BF9; Tue, 8 Feb 2022 10:12:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PgObKABCAmJDcgAAMHmgww (envelope-from ); Tue, 08 Feb 2022 10:12:16 +0000 Date: Tue, 8 Feb 2022 11:12:14 +0100 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm/memory_hotplug: fix misplaced comment in offline_pages Message-ID: References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-5-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207133643.23427-5-linmiaohe@huawei.com> X-Rspamd-Queue-Id: 65BC0140006 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=L8UEVSKr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rIsf6VLK; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Stat-Signature: refsgz9s55qfn5zsqi7yzd4ajkno314j X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1644315138-854689 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 07, 2022 at 09:36:43PM +0800, Miaohe Lin wrote: > It's misplaced since commit 7960509329c2 ("mm, memory_hotplug: print reason > for the offlining failure"). Move it to the right place. > > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 4b9eef861ee4..7dc7e12302db 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1966,6 +1966,7 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > return 0; > > failed_removal_isolated: > + /* pushback to free area */ > undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE); > memory_notify(MEM_CANCEL_OFFLINE, &arg); > failed_removal_pcplists_disabled: > @@ -1976,7 +1977,6 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > (unsigned long long) start_pfn << PAGE_SHIFT, > ((unsigned long long) end_pfn << PAGE_SHIFT) - 1, > reason); > - /* pushback to free area */ > mem_hotplug_done(); > return ret; > } > -- > 2.23.0 > > -- Oscar Salvador SUSE Labs