From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2BCC433EF for ; Tue, 8 Feb 2022 08:40:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B858A6B0082; Tue, 8 Feb 2022 03:40:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B361B6B0083; Tue, 8 Feb 2022 03:40:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0A896B0085; Tue, 8 Feb 2022 03:40:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 91F646B0082 for ; Tue, 8 Feb 2022 03:40:56 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4C3D5181CA087 for ; Tue, 8 Feb 2022 08:40:56 +0000 (UTC) X-FDA: 79118967312.24.F4BBD10 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf28.hostedemail.com (Postfix) with ESMTP id E742CC0002 for ; Tue, 8 Feb 2022 08:40:55 +0000 (UTC) Received: by mail-io1-f47.google.com with SMTP id m185so11939764iof.10 for ; Tue, 08 Feb 2022 00:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fSx772rzzfOHYeUS+/fgO/fHFWW4qH5p6y6tkCzuQFA=; b=AHqyiZiHhsX/3nWVek6Mk+Hpl9VkTBER5gY4+QxuoBwPffcCJSf1mFraEY+RXC44fp DWpdTlnJvmOfAhLEYM5+k5IhbMIz71LyVJXmRMsW2+L2Gf2PiOZ1UTwxRF8pqrMZ32Yb SArw/UKQsp144yuoCyeuTeK9iEmdIPdmTdu4W0I/mnGIANLuo9KxWM/ZQ5B04Yw68Sdo u5J2wcU9D7M2zFaZoIwG8GnBR6SFWwkueGRUKTetdx8TBz+KkYUu9JazYnirH3NNPxs9 budJlxxFq+5uiOX8/+GLWUOlbFRP/YnbsWPBsvNI4JVBLPqnK+9V/T9KSVwwae5C+rT5 jvVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fSx772rzzfOHYeUS+/fgO/fHFWW4qH5p6y6tkCzuQFA=; b=aMWGp5hzr5BTcXQb+kEzrelPRORbbliM8PRprXviLT8IkFLn5KsclEyOzdKJO13NdI FhapXhdksqNHCXrBN8YNw5lQQFtCjy5j6Q4MXftpEfugQKAbPHhrTG+58qef5p0JY7Wx nIkDqxPMXBZ12+bwZqcY8IEfNmNlPu5Iqsi4JzQpfyJytVacA+RNVuXNJaEmSUrF83c5 fu2BjCh2HjVXY0RmMsbh7pkigcYaCyK9ZjC8cF/LSQuYvi2eFL0gEHlaUiOF66CJSvGO dhOae7n2BZFV/dPaaUIsxBEgQndupUycVJeXP57ZKsjfqGsoYmprUe2zz6wl4CmDFgWq aKuw== X-Gm-Message-State: AOAM5314A2OLs1hEYvDOrOdW28PE/VLbG5caK4eKoX4Ffb9FkTtXnkRv T5BhBF6ZQpKTjzgbSYa3XgMpqw== X-Google-Smtp-Source: ABdhPJz/3x2s2v++jA5R1rqXH1GDSTTJ7J9vwJGyql2IY4BWAXJhvKNMtH68ZcF37X2wEKNQkGGLNQ== X-Received: by 2002:a05:6638:150d:: with SMTP id b13mr1677197jat.131.1644309653668; Tue, 08 Feb 2022 00:40:53 -0800 (PST) Received: from google.com ([2620:15c:183:200:5f31:19c3:21f5:7300]) by smtp.gmail.com with ESMTPSA id p16sm4556962ilm.85.2022.02.08.00.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 00:40:53 -0800 (PST) Date: Tue, 8 Feb 2022 01:40:49 -0700 From: Yu Zhao To: Andrew Morton , Johannes Weiner , Mel Gorman , Michal Hocko Cc: Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Michael Larabel , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh Subject: Re: [PATCH v7 06/12] mm: multigenerational LRU: exploit locality in rmap Message-ID: References: <20220208081902.3550911-1-yuzhao@google.com> <20220208081902.3550911-7-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220208081902.3550911-7-yuzhao@google.com> X-Rspamd-Queue-Id: E742CC0002 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AHqyiZiH; spf=pass (imf28.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: pif5dj5o71hbie15rx9suia1j37bmc6d X-Rspamd-Server: rspam04 X-HE-Tag: 1644309655-85302 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 08, 2022 at 01:18:56AM -0700, Yu Zhao wrote: > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index b72d75141e12..51c9bc8e965d 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -436,6 +436,7 @@ static inline struct obj_cgroup *__folio_objcg(struct folio *folio) > * - LRU isolation > * - lock_page_memcg() > * - exclusive reference > + * - mem_cgroup_trylock_pages() > * > * For a kmem folio a caller should hold an rcu read lock to protect memcg > * associated with a kmem folio from being released. > @@ -497,6 +498,7 @@ static inline struct mem_cgroup *folio_memcg_rcu(struct folio *folio) > * - LRU isolation > * - lock_page_memcg() > * - exclusive reference > + * - mem_cgroup_trylock_pages() > * > * For a kmem page a caller should hold an rcu read lock to protect memcg > * associated with a kmem page from being released. > @@ -934,6 +936,23 @@ void unlock_page_memcg(struct page *page); > > void __mod_memcg_state(struct mem_cgroup *memcg, int idx, int val); > > +/* try to stablize folio_memcg() for all the pages in a memcg */ > +static inline bool mem_cgroup_trylock_pages(struct mem_cgroup *memcg) > +{ > + rcu_read_lock(); > + > + if (mem_cgroup_disabled() || !atomic_read(&memcg->moving_account)) > + return true; > + > + rcu_read_unlock(); > + return false; > +} > + > +static inline void mem_cgroup_unlock_pages(void) > +{ > + rcu_read_unlock(); > +} Replaced the open-coded folio_memcg() lock with a new function mem_cgroup_trylock_pages() as requested here: https://lore.kernel.org/linux-mm/YeATr%2F%2FU6XD87fWF@dhcp22.suse.cz/