From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB86C433EF for ; Sun, 6 Feb 2022 20:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6D626B0072; Sun, 6 Feb 2022 15:46:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1DA66B0073; Sun, 6 Feb 2022 15:46:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBEE46B0074; Sun, 6 Feb 2022 15:46:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id BD43B6B0072 for ; Sun, 6 Feb 2022 15:46:51 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 473C9181DA54F for ; Sun, 6 Feb 2022 20:46:51 +0000 (UTC) X-FDA: 79113539022.18.DA9076B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id D0DE4180002 for ; Sun, 6 Feb 2022 20:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RNHB7IBpnhy7O1ocgj3YZzudmkDv9q8iWD+k6XTlaWc=; b=hNh9HJ5dK+tD2uA2GF/WMf94un fKwL9VA975Odmrk+HKicay0hWm3ntUy05vz/jSgsZjI5qj4Ri1lHVGdwWx7OlQ6Bg16K5ELGJqEy+ UZieiwwTGcRDZsUMKp6mef7620Q2xlUfq1TsGiuc3Qo3jIACPqDtwuiTdlffhe4JcUyaT0os9HgUR 3YwrvrXHSTgJNzt/Q5bzsPOnkAQGTuZfO7Utvclm7p9DZc2Gq4NMQOM7EJ81iOTervlPk4Nv3CqV1 mEZJd6SkEc53Iwi0CQ+Jcy4UNeeWkMsj+xxDr8vHmO1n+xXnW3ixPtNVDrxaivbLkBXOrAqdwKdiK tEigfOog==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGoQn-00Faff-UK; Sun, 06 Feb 2022 20:46:45 +0000 Date: Sun, 6 Feb 2022 20:46:45 +0000 From: Matthew Wilcox To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 41/75] hexagon: Add pmd_pfn() Message-ID: References: <20220204195852.1751729-1-willy@infradead.org> <20220204195852.1751729-42-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D0DE4180002 X-Stat-Signature: bm5gngtwwym1m7aih3mgwejwaaysjy6q Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hNh9HJ5d; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: nil X-HE-Tag: 1644180410-527663 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 06, 2022 at 08:13:11PM +0200, Mike Rapoport wrote: > On Fri, Feb 04, 2022 at 07:58:18PM +0000, Matthew Wilcox (Oracle) wrote: > > I need to use this function in common code, so define it for hexagon. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > arch/hexagon/include/asm/pgtable.h | 3 ++- > > Why hexagon out of all architectures? > What about m68k, nios2, nds32 etc? Presumably they don't support CONFIG_TRANSPARENT_HUGEPAGE. This code isn't compiled when THP are disabled; at least I haven't had a buildbot complaint for any other architectures. > > +#define pmd_pfn(pmd) (pmd_val(pmd) >> PAGE_SHIFT) > > I'd put it in include/linux/pgtable.h inside #ifndef pmd_pfn That's completely upside down. pmd_pfn() should be defined by each architecture (because generic code can't know anything about the format of PMDs); if anything pmd_page() should be defined in linux/pgtable.h in terms of pmd_pfn. I'm not signing up to do that work as part of this series. That seems like a distraction.