From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3364BC433F5 for ; Fri, 18 Feb 2022 08:01:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B45F16B0074; Fri, 18 Feb 2022 03:01:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACE9C6B0075; Fri, 18 Feb 2022 03:01:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96F586B0078; Fri, 18 Feb 2022 03:01:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 82C676B0074 for ; Fri, 18 Feb 2022 03:01:16 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 48F0D180A7F79 for ; Fri, 18 Feb 2022 08:01:16 +0000 (UTC) X-FDA: 79155155352.17.FDD7329 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id ACE5C40007 for ; Fri, 18 Feb 2022 08:01:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E57EC61269; Fri, 18 Feb 2022 08:01:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C17FC340E9; Fri, 18 Feb 2022 08:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645171274; bh=wlMKj3Vczzg2CXtGVuAuaNfHplfiJXvDzqzkB6AONQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=meXSLvfjyeKjeSTO3/guG9OP9lyEqngjge5GQ4Jkxme5Qsg30IPN13Pvt8KgZTiG6 8jrbmMG2+B60qLx5jS/DdONcm3Bj6042Q8asqr4Xv77To8xrSFuhAeihzNjv9roia8 vxbCvnM8bS6LDYfhP1+S+1eLUAnyBuZKkx60qOD4= Date: Fri, 18 Feb 2022 09:01:11 +0100 From: Greg KH To: SeongJae Park Cc: Yuanchu Xie , Shuah Khan , Markus Boehme , rientjes@google.com, Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] selftests/damon: make selftests executable Message-ID: References: <20220218001017.3500673-3-yuanchu@google.com> <20220218075254.11467-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220218075254.11467-1-sj@kernel.org> X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=meXSLvfj; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: ACE5C40007 X-Stat-Signature: i6jsik4tzbxfb8aqe14fk31uybqwh6n1 X-HE-Tag: 1645171275-823962 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote: > Hello Yuanchu, > > Thank you for this patch! > > On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie wrote: > > > The damon selftests do not have the executable bit on. We fix that by > > setting the x bits on the .sh files similar to other existing shell > > selftests. > > > > Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") > > Signed-off-by: Yuanchu Xie > > Reviewed-by: SeongJae Park This type of change does not work outside of git, so why not just make the tool that calls these scripts not care about the executable bit like we do for other scripts? thanks, greg k-h