From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C56C433EF for ; Thu, 17 Feb 2022 10:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 948A86B0075; Thu, 17 Feb 2022 05:40:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F7B56B0078; Thu, 17 Feb 2022 05:40:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BE586B007B; Thu, 17 Feb 2022 05:40:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 6FA096B0075 for ; Thu, 17 Feb 2022 05:40:36 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 235729519A for ; Thu, 17 Feb 2022 10:40:36 +0000 (UTC) X-FDA: 79151928072.16.C4EDA46 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf19.hostedemail.com (Postfix) with ESMTP id A9C021A0005 for ; Thu, 17 Feb 2022 10:40:35 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 39C7C1F383; Thu, 17 Feb 2022 10:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645094434; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xhmews3hiohUWVZ2fQnwuQzL2BmbTvELU6RjyghQi08=; b=jSj5Xuanh1Toei1k1Q94lP4CSI0WNhdInvMyC4HPu6A6CGm4EMQdOz9bHC57KuodIS0MwH UuB75aQ3gj3+Q026n8Y/iOmf5Itlhdnyi8ZkKCNZJb6EgOThcrH1N+1y8GEu9rZng9ws2l q9XS1+dbRRfkZIsK7WqMbeum/gneUxU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645094434; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xhmews3hiohUWVZ2fQnwuQzL2BmbTvELU6RjyghQi08=; b=+8TkWSof3pEdblEHBwaLdQU3g/jum9Hcr88Ej619ZPdU7vLezllD2tiYjulZstHXKlsaUM m8kPvFrAe2XHXkBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6217913DD8; Thu, 17 Feb 2022 10:40:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NX+bFCEmDmKuRQAAMHmgww (envelope-from ); Thu, 17 Feb 2022 10:40:33 +0000 Date: Thu, 17 Feb 2022 11:40:31 +0100 From: Oscar Salvador To: Michal Hocko Cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, LKML , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Tejun Heo , Christoph Lameter , Nico Pache , Wei Yang , Rafael Aquini Subject: Re: [PATCH 4/6] mm, memory_hotplug: reorganize new pgdat initialization Message-ID: References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-5-mhocko@kernel.org> <6db33bb0-c72a-5539-5873-14039702e2a3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A9C021A0005 X-Stat-Signature: idicwub3n83smn7iuef7xdprft3bt9ks Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=jSj5Xuan; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+8TkWSof; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf19.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-HE-Tag: 1645094435-617491 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 03:44:21PM +0100, Michal Hocko wrote: > > I feel like we should be initializing all of this only once, just after > > allocating the node. There should be no difference between a node we're > > reusing and a "fresh" node. IOW, memory offlining should be resetting > > all state accordingly when the last memory goes away. > > > > But I might be wrong and this patch looks like an improvement, as you > > say, without functional change > > Yeah, I really wanted to have this simple and straightforward. To be > completely honest I am not even sure this is necessary. Something really > woth looking at. Seizing the opportunity that I had to look at this code and at x86's numa init code again I am preparing something to further sort this out and simplify it a bit. So I will have something soon unless someone beats me to it first. -- Oscar Salvador SUSE Labs