From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD55C433EF for ; Fri, 18 Feb 2022 18:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73B596B0074; Fri, 18 Feb 2022 13:46:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EA806B0075; Fri, 18 Feb 2022 13:46:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B18B6B0078; Fri, 18 Feb 2022 13:46:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id 478E56B0074 for ; Fri, 18 Feb 2022 13:46:42 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0605B84773 for ; Fri, 18 Feb 2022 18:46:42 +0000 (UTC) X-FDA: 79156781844.06.5D91EB7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id EC49E16000E for ; Fri, 18 Feb 2022 18:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tx5f0UJcnj4R4TQ9Q7WxhcrF/JhIh7OvVd5/el1oJq8=; b=ey0q4gnDN4OAF8aBKVU9l6rjjr SrFhHlNWfk+cJDXcEuK4fKsOj3WawdGMMseCJOjiKTJ5jRGKcWNSnmD+LjeKbgGcgkXWzUARq2tjr ph6jmD0I8IIjefo+toFeEoo+1isV3SavZG/j7vTRZcBE6b8xWFJFmnWVVZ1ONQuEghbzYsjMg7uM3 bBuHy1zb+Rmrp+xa8pj1Y2cR7or9Nroof+zEaVCzm8w84Xy+1fvD+tEDFREbdSx7jY/x/uhgDqP8h KE1g9nBEtg6E3VAx0tMSIRhvFMfCb+vBrpAiPh0ERnNNXwt1U9KPowUk/lcBMa2DsN/M/neeuOOe4 i/J1cHwg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nL8Gz-00Gq2v-9i; Fri, 18 Feb 2022 18:46:29 +0000 Date: Fri, 18 Feb 2022 18:46:29 +0000 From: Matthew Wilcox To: Steven Rostedt Cc: Jakub =?utf-8?Q?Mat=C4=9Bna?= , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org, mgorman@techsingularity.net, liam.howlett@oracle.com, hughd@google.com, kirill@shutemov.name, riel@surriel.com, peterz@infradead.org Subject: Re: [RFC PATCH 4/4] [PATCH 4/4] mm: add tracing for VMA merges Message-ID: References: <20220218122019.130274-1-matenajakub@gmail.com> <20220218122019.130274-5-matenajakub@gmail.com> <20220218130920.5902d967@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220218130920.5902d967@gandalf.local.home> Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ey0q4gnD; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EC49E16000E X-Stat-Signature: sqso49sdqc9696ufxtnreagdrhigf75w X-HE-Tag: 1645210000-709196 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 18, 2022 at 01:09:20PM -0500, Steven Rostedt wrote: > Please indent the above better. That is: > > __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) > + (merge_next == AV_MERGE_DIFFERENT) > + (merge_both == AV_MERGE_DIFFERENT); I thought our coding style preferred trailing operators; that is: __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) + (merge_next == AV_MERGE_DIFFERENT) + (merge_both == AV_MERGE_DIFFERENT);