From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDCBC433EF for ; Thu, 3 Feb 2022 11:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CDCC8D0143; Thu, 3 Feb 2022 06:09:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97D898D0129; Thu, 3 Feb 2022 06:09:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 893788D0143; Thu, 3 Feb 2022 06:09:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 7AE4E8D0129 for ; Thu, 3 Feb 2022 06:09:22 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 348D59991A for ; Thu, 3 Feb 2022 11:09:22 +0000 (UTC) X-FDA: 79101197364.15.3755D11 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf03.hostedemail.com (Postfix) with ESMTP id B53A820002 for ; Thu, 3 Feb 2022 11:09:21 +0000 (UTC) Date: Thu, 3 Feb 2022 12:09:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1643886559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P9dLipNCWTDLjIRcvw1w4KRMkmUCKyaDC+LsdcGILXU=; b=QDRNCbwJulSq9t5Xh04HOv8ePTtDVfMuQTt034qeBLsgpE80y7cSOplg5bJpS4uJZGhtw+ wc6UOjq9UPSmDE+YXuNGXbMmKbJTJIZ9XjsxFEwJm+6NqD5o0M+efshiP1Ly/7Um07CnOP 15pzvzuzjhWRNVTdsHEzGEMQfBpENqgwsGzg+mdCV1jF0C8x4l+qUyYITGj82dfL7uoEGW xfZ9x5TOmiH/abavhKVmtWfn4+B7Uc9qnvFSrDhNeWKzHBYG2/KPfTL7u1V2qrj0egy8M/ ZAINbkF5Iyf55flNQmaaGlemu8KmMQR92BnxP6cqvFuGHFeRmQ3Jzfdp95Ew7w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1643886559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P9dLipNCWTDLjIRcvw1w4KRMkmUCKyaDC+LsdcGILXU=; b=lwUjPEVsfXIfH935kV3JAUFh5s5hYmrfTNIqfAtlPw/iNkPURp5YZyrDHhydvyywD+rzqM kvt2dX0TvgEVtmCA== From: Sebastian Andrzej Siewior To: Michal Hocko Cc: Waiman Long , cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Michal =?utf-8?Q?Koutn=C3=BD?= , Peter Zijlstra , Thomas Gleixner , Vladimir Davydov Subject: Re: [PATCH 3/4] mm/memcg: Add a local_lock_t for IRQ and TASK object. Message-ID: References: <20220125164337.2071854-1-bigeasy@linutronix.de> <20220125164337.2071854-4-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B53A820002 X-Stat-Signature: 6drcryfez6dhgwkd1jtrnzhnbz96wumu X-Rspam-User: nil Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=QDRNCbwJ; dkim=pass header.d=linutronix.de header.s=2020e header.b=lwUjPEVs; spf=pass (imf03.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-HE-Tag: 1643886561-70976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-02-03 11:09:57 [+0100], Michal Hocko wrote: > Thanks for this test. I do assume that both have been run inside a > non-root memcg. I did run after a regular login on a Debian unstable installation. I did confirm via trace_printk() that get_obj_stock() was invoked from process and interrupt context and the caller was cc1 and so on. > Weiman, what was the original motivation for 559271146efc0? Because as > this RT patch shows it makes future changes much more complex and I > would prefer a simpler and easier to maintain code than some micro > optimizations that do not have any visible effect on real workloads. Sebastian