From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F61C433FE for ; Tue, 1 Feb 2022 15:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02B956B01F5; Tue, 1 Feb 2022 10:29:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1D056B01F7; Tue, 1 Feb 2022 10:29:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE5276B01F8; Tue, 1 Feb 2022 10:29:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id D0BF76B01F5 for ; Tue, 1 Feb 2022 10:29:37 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8D1381816C8DF for ; Tue, 1 Feb 2022 15:29:37 +0000 (UTC) X-FDA: 79094595594.16.85AE6CD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf17.hostedemail.com (Postfix) with ESMTP id BA61440007 for ; Tue, 1 Feb 2022 15:29:36 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 7FB222110A; Tue, 1 Feb 2022 15:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1643729375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zSBg3nPWuNIwbLhGHez+BKTr0BYdn5qn2z9ShJZjgw8=; b=r9uApZUC2gSP8IWVhMEXOBCd81yy+Rrx+VyO5jX55MI1A0eqMr6RgEcnASEW/oOxPXo0dy Os/1BBc6LyHfW8ISc8Oc1cDkOi5TC+kFpwKWio/8eOK8RocMKYsP3j6FqFwH6X/0HljnYc YnP3+cnHuO5EXywFEEZEJsBTfBd4eIQ= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 6A1AEA3B84; Tue, 1 Feb 2022 15:29:35 +0000 (UTC) Date: Tue, 1 Feb 2022 16:29:35 +0100 From: Michal Hocko To: Sebastian Andrzej Siewior , Waiman Long Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Peter Zijlstra , Thomas Gleixner , Vladimir Davydov Subject: Re: [PATCH 3/4] mm/memcg: Add a local_lock_t for IRQ and TASK object. Message-ID: References: <20220125164337.2071854-1-bigeasy@linutronix.de> <20220125164337.2071854-4-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BA61440007 X-Stat-Signature: aukgu1sdqgxep9sx8qy9iipau8qb8rxp Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=r9uApZUC; spf=pass (imf17.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1643729376-172561 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 01-02-22 13:11:57, Sebastian Andrzej Siewior wrote: > On 2022-02-01 13:04:02 [+0100], Michal Hocko wrote: > > > > Thanks! This gives us some picture from the microbenchmark POV. I was > > more interested in some real life representative benchmarks. In other > > words does the optimization from Weiman make any visible difference for > > any real life workload? > > my understanding is that this was micro-benchmark driven. Weiman was this driven by any real world workload? > > Sorry, I know that this all is not really related to your work but if > > the original optimization is solely based on artificial benchmarks then > > I would rather drop it and also make your RT patchset easier. > > Do you have any real-world benchmark in mind? Like something that is > already used for testing/ benchmarking and would fit here? Anything that even remotely resembles a real allocation heavy workload. -- Michal Hocko SUSE Labs