* [PATCH v2] selftests/ir: fix build with ancient kernel headers
@ 2022-02-01 18:38 Sean Young
2022-02-04 20:45 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Sean Young @ 2022-02-01 18:38 UTC (permalink / raw)
To: Shuah Khan
Cc: Matthew Wilcox, Alexei Starovoitov, kernel test robot,
Alexei Starovoitov, LKML, Linux Memory Management List, lkp,
kbuild test robot
Since commit e2bcbd7769ee ("tools headers UAPI: remove stale lirc.h"),
the build of the selftests fails on rhel 8 since its version of
/usr/include/linux/lirc.h has no definition of RC_PROTO_RCMM32, etc [1].
[1] https://lkml.org/lkml/2022/1/28/275
Fixes: e2bcbd7769ee ("tools headers UAPI: remove stale lirc.h")
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Sean Young <sean@mess.org>
---
tools/testing/selftests/ir/ir_loopback.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tools/testing/selftests/ir/ir_loopback.c b/tools/testing/selftests/ir/ir_loopback.c
index 06256c96df12..f4a15cbdd5ea 100644
--- a/tools/testing/selftests/ir/ir_loopback.c
+++ b/tools/testing/selftests/ir/ir_loopback.c
@@ -29,6 +29,16 @@
#define SYSFS_PATH_MAX 256
#define DNAME_PATH_MAX 256
+/*
+ * Support ancient lirc.h which does not have these values. Can be removed
+ * once RHEL 8 is no longer a relevant testing platform.
+ */
+#if RC_PROTO_MAX < 26
+#define RC_PROTO_RCMM12 24
+#define RC_PROTO_RCMM24 25
+#define RC_PROTO_RCMM32 26
+#endif
+
static const struct {
enum rc_proto proto;
const char *name;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] selftests/ir: fix build with ancient kernel headers
2022-02-01 18:38 [PATCH v2] selftests/ir: fix build with ancient kernel headers Sean Young
@ 2022-02-04 20:45 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2022-02-04 20:45 UTC (permalink / raw)
To: Sean Young
Cc: Matthew Wilcox, Alexei Starovoitov, kernel test robot,
Alexei Starovoitov, LKML, Linux Memory Management List, lkp,
kbuild test robot, Shuah Khan
On 2/1/22 11:38 AM, Sean Young wrote:
> Since commit e2bcbd7769ee ("tools headers UAPI: remove stale lirc.h"),
> the build of the selftests fails on rhel 8 since its version of
> /usr/include/linux/lirc.h has no definition of RC_PROTO_RCMM32, etc [1].
>
> [1] https://lkml.org/lkml/2022/1/28/275
>
> Fixes: e2bcbd7769ee ("tools headers UAPI: remove stale lirc.h")
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Signed-off-by: Sean Young <sean@mess.org>
> ---
Applied now to linux-kselftest fixes branch - decided to take
it through since there is no real dependency on previous patch
as far as the change goes.
Fixes: e2bcbd7769ee ("tools headers UAPI: remove stale lirc.h")
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-04 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 18:38 [PATCH v2] selftests/ir: fix build with ancient kernel headers Sean Young
2022-02-04 20:45 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox