From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FFBC433F5 for ; Tue, 1 Feb 2022 09:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2413E8D005F; Tue, 1 Feb 2022 04:51:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F0AA8D0054; Tue, 1 Feb 2022 04:51:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B93E8D005F; Tue, 1 Feb 2022 04:51:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id EDF558D0054 for ; Tue, 1 Feb 2022 04:51:41 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 97F7092747 for ; Tue, 1 Feb 2022 09:51:41 +0000 (UTC) X-FDA: 79093744002.31.F32802F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id 07BA4160003 for ; Tue, 1 Feb 2022 09:51:40 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A31A81F383; Tue, 1 Feb 2022 09:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1643709099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aXtpcbJyDyk4mWH2FPATZeadgV4+yzsbRgqmF24oHa4=; b=OMiyGHQYaQUqTDF5tmaaHhkhcGdEldbHEITKVnuK6dPYV56pnh7Z0gWgx9TqGo+dF+QMXv +PjZStCvY+miMlj1c1TlikXtuSEX6bnY2jPxKUPNVBwsDEJPs29RippT1erCf8UfGh/Dk5 Qd9epi9v5DzYcvVB/bmawc/0Q3/2F5Q= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 66F41A3B85; Tue, 1 Feb 2022 09:51:39 +0000 (UTC) Date: Tue, 1 Feb 2022 10:51:39 +0100 From: Michal Hocko To: Wei Yang Cc: Andrew Morton , linux-mm@kvack.org, LKML , David Hildenbrand , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Oscar Salvador , Tejun Heo , Christoph Lameter , Nico Pache , Rafael Aquini Subject: Re: [PATCH 6/6] memcg: do not tweak node in alloc_mem_cgroup_per_node_info Message-ID: References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-7-mhocko@kernel.org> <20220201024544.p2iqj2mz7bgq4pf3@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220201024544.p2iqj2mz7bgq4pf3@master> Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=OMiyGHQY; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: nil X-Rspamd-Queue-Id: 07BA4160003 X-Stat-Signature: g6h7wb8itnquszwftb58y9w3kte7mcps X-Rspamd-Server: rspam12 X-HE-Tag: 1643709100-221109 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 01-02-22 02:45:44, Wei Yang wrote: > On Thu, Jan 27, 2022 at 09:53:05AM +0100, Michal Hocko wrote: > >From: Wei Yang > > > >alloc_mem_cgroup_per_node_info is allocated for each possible node and > >this used to be a problem because not !node_online nodes didn't have > ^^^ a typo here? > > !node_online nodes is enough? Yes. Fixed up. Thx! > >appropriate data structure allocated. This has changed by "mm: handle > >uninitialized numa nodes gracefully" so we can drop the special casing > >here. > > > >Signed-off-by: Wei Yang > >Signed-off-by: Michal Hocko > > -- > Wei Yang > Help you, Help me -- Michal Hocko SUSE Labs