From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 061BBC433F5 for ; Tue, 1 Feb 2022 08:30:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77F118D005B; Tue, 1 Feb 2022 03:30:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72E5F8D0054; Tue, 1 Feb 2022 03:30:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F6E38D005B; Tue, 1 Feb 2022 03:30:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 4E5268D0054 for ; Tue, 1 Feb 2022 03:30:23 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 02FF5181CAC7C for ; Tue, 1 Feb 2022 08:30:23 +0000 (UTC) X-FDA: 79093539126.09.CA4F597 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf15.hostedemail.com (Postfix) with ESMTP id A3E9CA0002 for ; Tue, 1 Feb 2022 08:30:22 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id y15so32142145lfa.9 for ; Tue, 01 Feb 2022 00:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ul3s4D/Hp2YNz1ehPnbUO3CCYBCPQRY60603bZrCUHg=; b=maBdNT8Jy5fUIq8duhY9BbnAsx1koD8nEsiEJgSxO0XEpcqUFAg6vcB7HRx58kKy+g v2LklwjvCMyJ1vY7gIHq8Ingp2/cKFo39Uzsz1I4fc7D2Q7S2M602gEcuGtxUBmJoYyN 8yBieWWGzUgHl7/oEhmUPM06duJsTiyvGV23N1S5CqQG2CkY1fvteCL+tjpbKvXxM0wJ g+3ePXlLizEmhwUT8Z5bKn21OejDfTshRhhrfuTa+Ksnn2yHLW3t1BYf5Z6ckxrfsqrE h5mPEv6Hu2ZzAzQtWCqvxA3NoZ1x787YQGY7RktTv2nU6IAUXVfIP44mbl2Fhyddtbym ufEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ul3s4D/Hp2YNz1ehPnbUO3CCYBCPQRY60603bZrCUHg=; b=WY/r6U+2Qr8Ayy/QhsD7wfj/aIREQ/Z7/jUWacCfPlhXSlsagu3hClbiV4a6+QAgpr rJzdjmGtd7O4vxQnODVTdJBQOgl9LLVOWLMT4j3sHIr/o2pmnQZ22lxlJb7OUu+IyIio UM/YNpvzsIbg2BF8+OPY+TkUoAaPBak2lcu2XWoxdmG77umVTd/wISzrBY2wAdnmhn+e pypYKE0bl0s4MSZuEhwC+QY5jvMdhFIvno4Il4y48ECDtSlY7Qqa/M8ZhzjaK+f+6MlS xtczdSyK+EpRzIxwBZ5mGTHh/nhOOdn7w0HbcGQsEYupcsRIATsWEsFDJgi2YHGyd3/D dQyQ== X-Gm-Message-State: AOAM5302DPx+duUfl0ZNuuQUvJJl1SAMv7NEHDUkyXlBu/oVIDD99qay vL0CU1pZ8hPESf8pP3bgm0s= X-Google-Smtp-Source: ABdhPJwP0XctlY9X3lZ9b/5KRaAEWdrfxdbA8ggY+BKga62pAjY3/B0FVDE7agE1BocsoEkvbiS47w== X-Received: by 2002:a19:6a12:: with SMTP id u18mr18232631lfu.348.1643704220935; Tue, 01 Feb 2022 00:30:20 -0800 (PST) Received: from pc638.lan ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id q5sm3985122lfg.77.2022.02.01.00.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 00:30:20 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 1 Feb 2022 09:30:18 +0100 To: Jiapeng Chong Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] mm/vmalloc.c: Fix "unused function" warning Message-ID: References: <20220129034652.75359-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220129034652.75359-1-jiapeng.chong@linux.alibaba.com> X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A3E9CA0002 X-Stat-Signature: 75p6ziopa7omroteh18iwfnjqj9mz1ja Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=maBdNT8J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com X-HE-Tag: 1643704222-527624 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000079, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > compute_subtree_max_size() is unused, when building with > DEBUG_AUGMENT_PROPAGATE_CHECK=y. > Nit: vice versa? It is only used when DEBUG_AUGMENT_PROPAGATE_CHECK=y > mm/vmalloc.c:785:1: warning: unused function 'compute_subtree_max_size' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > mm/vmalloc.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 028ce2b9bbf9..42d37b4bd351 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -778,17 +778,6 @@ get_subtree_max_size(struct rb_node *node) > return va ? va->subtree_max_size : 0; > } > > -/* > - * Gets called when remove the node and rotate. > - */ > -static __always_inline unsigned long > -compute_subtree_max_size(struct vmap_area *va) > -{ > - return max3(va_size(va), > - get_subtree_max_size(va->rb_node.rb_left), > - get_subtree_max_size(va->rb_node.rb_right)); > -} > - > RB_DECLARE_CALLBACKS_MAX(static, free_vmap_area_rb_augment_cb, > struct vmap_area, rb_node, unsigned long, subtree_max_size, va_size) > > @@ -978,6 +967,17 @@ unlink_va(struct vmap_area *va, struct rb_root *root) > } > > #if DEBUG_AUGMENT_PROPAGATE_CHECK > +/* > + * Gets called when remove the node and rotate. > + */ > +static __always_inline unsigned long > +compute_subtree_max_size(struct vmap_area *va) > +{ > + return max3(va_size(va), > + get_subtree_max_size(va->rb_node.rb_left), > + get_subtree_max_size(va->rb_node.rb_right)); > +} > + > static void > augment_tree_propagate_check(void) > { > -- > 2.20.1.7.g153144c > Reviewed-by: Uladzislau Rezki (Sony) -- Vlad Rezki